Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 2732213007: [MD settings] keep dropdown menu same width when adding indicator (Closed)

Created:
3 years, 9 months ago by dschuyler
Modified:
3 years, 9 months ago
Reviewers:
dpapad
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, dcheng, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] keep dropdown menu same width when adding indicator This CL moves the spacing around a controlled-by indicator to the indictor itself, so that the width of the dropdown menu no longer changes. BUG=699486 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2732213007 Cr-Commit-Position: refs/heads/master@{#455641} Committed: https://chromium.googlesource.com/chromium/src/+/27e9e232d7a4b8c3e255925093f51d8de8fcf63e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M chrome/browser/resources/settings/controls/settings_dropdown_menu.html View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
dschuyler
3 years, 9 months ago (2017-03-08 22:22:42 UTC) #4
dpapad
lgtm
3 years, 9 months ago (2017-03-08 22:56:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2732213007/1
3 years, 9 months ago (2017-03-09 00:03:24 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/336707)
3 years, 9 months ago (2017-03-09 00:32:56 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2732213007/1
3 years, 9 months ago (2017-03-09 02:12:32 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 02:18:08 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/27e9e232d7a4b8c3e255925093f5...

Powered by Google App Engine
This is Rietveld 408576698