Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 2732213006: [Child Accounts] Update settings link string for sign in (Closed)

Created:
3 years, 9 months ago by dgn
Modified:
3 years, 9 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, srahim+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Child Accounts] Update settings link string for sign in BUG=698231 Review-Url: https://codereview.chromium.org/2732213006 Cr-Commit-Position: refs/heads/master@{#455726} Committed: https://chromium.googlesource.com/chromium/src/+/ea7669c009692703286a55c3ac90ae1e11178501

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninView.java View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/java/strings/android_chrome_strings.grd View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
dgn
PTAL. Preview: https://goo.gl/photos/giWVXoTRaxwqfZiV7
3 years, 9 months ago (2017-03-08 18:19:29 UTC) #3
Bernhard Bauer
LGTM, thanks! https://codereview.chromium.org/2732213006/diff/1/chrome/android/java/strings/android_chrome_strings.grd File chrome/android/java/strings/android_chrome_strings.grd (right): https://codereview.chromium.org/2732213006/diff/1/chrome/android/java/strings/android_chrome_strings.grd#newcode1978 chrome/android/java/strings/android_chrome_strings.grd:1978: <message name="IDS_SIGNIN_SIGNED_IN_SETTINGS_DESCRIPTION_UCA" desc="Label of the section containing ...
3 years, 9 months ago (2017-03-08 18:40:14 UTC) #5
dgn
Thanks! https://codereview.chromium.org/2732213006/diff/1/chrome/android/java/strings/android_chrome_strings.grd File chrome/android/java/strings/android_chrome_strings.grd (right): https://codereview.chromium.org/2732213006/diff/1/chrome/android/java/strings/android_chrome_strings.grd#newcode1978 chrome/android/java/strings/android_chrome_strings.grd:1978: <message name="IDS_SIGNIN_SIGNED_IN_SETTINGS_DESCRIPTION_UCA" desc="Label of the section containing the ...
3 years, 9 months ago (2017-03-09 11:14:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2732213006/20001
3 years, 9 months ago (2017-03-09 11:15:21 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 13:17:54 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ea7669c009692703286a55c3ac90...

Powered by Google App Engine
This is Rietveld 408576698