Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2732213005: Revert "This is a speculative chain of reverts to improve a Chrome" (Closed)

Created:
3 years, 9 months ago by binji
Modified:
3 years, 9 months ago
Reviewers:
Dan Ehrenberg, adamk
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan, Yang
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland moving Atomics builtins to C++ This reverts the previous revert, commit 5a04f4fd68d1d35d704cdc0dee0719c5354a8094. Previously reverted changes: > Revert "[SAB] Move Atomics builtins to C++" > > This reverts commit 2b9840d86f3b51f42918b6bf1a06ff8b62b2464d. > > Revert "[SAB] Remove unreachable Uint8Clamped atomics paths" > > This reverts commit d1160fb14f767f230f4d276b4bef49f846bb7a94. > > Revert "Remove tiny unit test for MinSimple/MaxSimple" > > This reverts commit 837760ecb7ff2ccaf7921ab46e7b473b313d4a4d. > > Revert "Remove infrastructure for experimental JS natives" > > This reverts commit 8cfe45b6f1880008d09d4310458b6e6fcb0522dd. These changes were reverted to improve a perf regression on a Chrome bot. Since then, the regression has reappeared, then disappeared again all from seemingly unrelated changes. BUG=v8:6033 TBR=adamk@chromium.org,hpayer@chromium.org,yangguo@chromium.org Review-Url: https://codereview.chromium.org/2732213005 Cr-Commit-Position: refs/heads/master@{#43758} Committed: https://chromium.googlesource.com/v8/v8/+/65200967b735be0cd91593ffb03fb96ee90df1a0

Patch Set 1 #

Patch Set 2 : merge master #

Patch Set 3 : remove some C++ exchange stuff from builtin-sharedarraybuffer #

Patch Set 4 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+656 lines, -936 lines) Patch
M BUILD.gn View 1 2 3 8 chunks +0 lines, -44 lines 0 comments Download
M src/bootstrapper.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/bootstrapper.cc View 1 2 3 10 chunks +23 lines, -93 lines 0 comments Download
M src/builtins/builtins.h View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download
M src/builtins/builtins-sharedarraybuffer.cc View 1 2 2 chunks +605 lines, -0 lines 0 comments Download
M src/debug/mirrors.js View 1 chunk +4 lines, -11 lines 0 comments Download
M src/heap/heap.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/heap/heap.cc View 1 chunk +0 lines, -3 lines 0 comments Download
D src/js/harmony-atomics.js View 1 chunk +0 lines, -152 lines 0 comments Download
M src/js/prologue.js View 5 chunks +5 lines, -100 lines 0 comments Download
M src/runtime/runtime.h View 1 2 3 1 chunk +0 lines, -9 lines 0 comments Download
M src/runtime/runtime-atomics.cc View 7 chunks +0 lines, -401 lines 0 comments Download
M src/runtime/runtime-futex.cc View 1 chunk +0 lines, -38 lines 0 comments Download
M src/snapshot/natives.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/snapshot/natives-common.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/snapshot/natives-external.cc View 3 chunks +0 lines, -4 lines 0 comments Download
M src/v8.gyp View 1 5 chunks +0 lines, -41 lines 0 comments Download
M test/cctest/heap/test-spaces.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/mjsunit/harmony/futex.js View 1 chunk +8 lines, -0 lines 0 comments Download
D test/mjsunit/minmax-simple.js View 1 chunk +0 lines, -27 lines 0 comments Download

Messages

Total messages: 28 (18 generated)
binji
3 years, 9 months ago (2017-03-08 02:43:47 UTC) #6
adamk
Thanks for putting this together! But: 1. We should wait till I+TF makes it to ...
3 years, 9 months ago (2017-03-08 06:03:29 UTC) #7
binji
OK, how's this for a better description?
3 years, 9 months ago (2017-03-10 19:21:21 UTC) #9
adamk
Looks good...let's aim to land this on Monday?
3 years, 9 months ago (2017-03-10 19:22:37 UTC) #10
binji
On 2017/03/10 19:22:37, adamk wrote: > Looks good...let's aim to land this on Monday? sgtm
3 years, 9 months ago (2017-03-10 19:28:10 UTC) #11
adamk
lgtm so this can land once the tree is un-throttled
3 years, 9 months ago (2017-03-10 19:30:47 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2732213005/60001
3 years, 9 months ago (2017-03-13 18:48:14 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/36502)
3 years, 9 months ago (2017-03-13 18:52:25 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2732213005/60001
3 years, 9 months ago (2017-03-13 20:57:37 UTC) #25
commit-bot: I haz the power
3 years, 9 months ago (2017-03-13 20:59:26 UTC) #28
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/v8/v8/+/65200967b735be0cd91593ffb03fb96ee90...

Powered by Google App Engine
This is Rietveld 408576698