Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Issue 2732113002: Move ::selection invalidation to applyPseudoStyleChanges. (Closed)

Created:
3 years, 9 months ago by rune
Modified:
3 years, 9 months ago
CC:
chromium-reviews, pdr+renderingwatchlist_chromium.org, blink-reviews-style_chromium.org, zoltan1, blink-reviews-layout_chromium.org, szager+layoutwatch_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move ::selection invalidation to applyPseudoStyleChanges. Removed need for separate StyleDifference constant for ::selection and otherwise simplified the code. R=mstensho@opera.com Review-Url: https://codereview.chromium.org/2732113002 Cr-Commit-Position: refs/heads/master@{#455262} Committed: https://chromium.googlesource.com/chromium/src/+/497a15a7742c476a3105d71ef27ed7029f10344f

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -26 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 1 2 chunks +3 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.cpp View 2 chunks +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleDifference.h View 2 chunks +1 line, -11 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
rune
ptal
3 years, 9 months ago (2017-03-06 22:04:27 UTC) #3
mstensho (USE GERRIT)
lgtm
3 years, 9 months ago (2017-03-07 10:04:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2732113002/20001
3 years, 9 months ago (2017-03-07 18:30:25 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-07 22:43:14 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/497a15a7742c476a3105d71ef27e...

Powered by Google App Engine
This is Rietveld 408576698