Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 2732073005: [DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. (Closed)

Created:
3 years, 9 months ago by ymzhang1
Modified:
3 years, 9 months ago
Reviewers:
clamy, Charlie Reis, alexmos
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. We are adding COMPONENT/TEAM information into OWNERS file (frame_host). Proposal to add TEAM/COMPONENT information into OWNERS files http://bit.ly/add-team-component-proposal Proposal about how to get suggested component for directory. http://bit.ly/directory-mapping-proposal TEAM-COMPONENT mapping http://bit.ly/component-team-mapping Additional Information: Component lists https://bugs.chromium.org/p/chromium/adminComponents BUG=679905 R=alexmos@chromium.org, clamy@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2732073005 Cr-Commit-Position: refs/heads/master@{#455807} Committed: https://chromium.googlesource.com/chromium/src/+/ce4a26c9271b0d16f4be5bb2433313113d9a2d24

Patch Set 1 #

Patch Set 2 : update component and owner list #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M content/browser/frame_host/OWNERS View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
ymzhang1
Hello, We are adding COMPONENT/TEAM information into OWNERS file. Would you mind helping us to ...
3 years, 9 months ago (2017-03-08 22:00:24 UTC) #2
alexmos
Is it possible to include multiple components for frame_host? It's associated with at least UI>Browser>Navigation ...
3 years, 9 months ago (2017-03-09 01:05:36 UTC) #4
ymzhang1
On 2017/03/09 01:05:36, alexmos wrote: > Is it possible to include multiple components for frame_host? ...
3 years, 9 months ago (2017-03-09 02:18:19 UTC) #5
Charlie Reis
On 2017/03/09 02:18:19, ymzhang1 wrote: > On 2017/03/09 01:05:36, alexmos wrote: > > Is it ...
3 years, 9 months ago (2017-03-09 17:16:48 UTC) #6
ymzhang1
Thanks for all comments!
3 years, 9 months ago (2017-03-09 18:16:10 UTC) #7
Charlie Reis
Thanks! LGTM.
3 years, 9 months ago (2017-03-09 18:19:40 UTC) #8
alexmos
LGTM
3 years, 9 months ago (2017-03-09 18:23:06 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2732073005/20001
3 years, 9 months ago (2017-03-09 18:29:21 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 18:43:01 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ce4a26c9271b0d16f4be5bb24333...

Powered by Google App Engine
This is Rietveld 408576698