Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2732063005: Revert of Remove a scoped_refptr<>::swap overload (Closed)

Created:
3 years, 9 months ago by estevenson
Modified:
3 years, 9 months ago
Reviewers:
jkarlin, xhwang, dcheng, tzik
CC:
chromium-reviews, cbentzel+watch_chromium.org, gavinp+disk_chromium.org, vmpstr+watch_chromium.org, posciak+watch_chromium.org, gavinp+memory_chromium.org, net-reviews_chromium.org, feature-media-reviews_chromium.org, gavinp
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove a scoped_refptr<>::swap overload (patchset #4 id:60001 of https://codereview.chromium.org/2723083004/ ) Reason for revert: Broke https://build.chromium.org/p/chromium.android/builders/Android%20x64%20Builder%20%28dbg%29/builds/15131 Original issue's description: > Remove a scoped_refptr<>::swap overload > > A scoped_refptr<>::swap overload is used to insert or remove the internal > pointer without manipulating the ref count. That functionality should not > be exposed, or at least, should be exposed separately with better name. > > This CL removes the swap() overload, and rewrites callers without swap(). > > Review-Url: https://codereview.chromium.org/2723083004 > Cr-Commit-Position: refs/heads/master@{#455407} > Committed: https://chromium.googlesource.com/chromium/src/+/511c810d540422faf221bd82a4532313cabcc4c4 TBR=dcheng@chromium.org,jkarlin@chromium.org,xhwang@chromium.org,tzik@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2732063005 Cr-Commit-Position: refs/heads/master@{#455456} Committed: https://chromium.googlesource.com/chromium/src/+/ae6bbc0f6bed9bb278889e3548b3a7fa1d9e84ef

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -10 lines) Patch
M base/memory/ref_counted.h View 2 chunks +9 lines, -2 lines 0 comments Download
M media/filters/ffmpeg_audio_decoder.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M media/filters/ffmpeg_video_decoder.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
estevenson
Created Revert of Remove a scoped_refptr<>::swap overload
3 years, 9 months ago (2017-03-08 15:24:07 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2732063005/1
3 years, 9 months ago (2017-03-08 15:30:51 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-08 15:32:56 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ae6bbc0f6bed9bb278889e3548b3...

Powered by Google App Engine
This is Rietveld 408576698