Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 2732053002: [heap] Implement simple marking in the concurrent marking thread. (Closed)

Created:
3 years, 9 months ago by ulan
Modified:
3 years, 9 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Implement simple marking in the concurrent marking thread. The concurrent marker uses ObjectVisitor to iterate pointers in objects and local marking bitmaps to keep track of visited objects. To keep it simple for now, I removed support for multiple tasks and canceling unfinished tasks. BUG=chromium:694255 Review-Url: https://codereview.chromium.org/2732053002 Cr-Commit-Position: refs/heads/master@{#43618} Committed: https://chromium.googlesource.com/v8/v8/+/a3923ce210c305fda4ec3f4d97f5a55f99e47b89

Patch Set 1 #

Patch Set 2 : re-upload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -52 lines) Patch
M src/heap/concurrent-marking.h View 2 chunks +7 lines, -14 lines 0 comments Download
M src/heap/concurrent-marking.cc View 3 chunks +83 lines, -31 lines 0 comments Download
M src/heap/marking.h View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/heap/test-concurrent-marking.cc View 1 chunk +3 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
ulan
ptal
3 years, 9 months ago (2017-03-06 18:57:30 UTC) #3
Michael Lippautz
lgtm
3 years, 9 months ago (2017-03-06 19:02:41 UTC) #4
Hannes Payer (out of office)
lgtm
3 years, 9 months ago (2017-03-06 19:45:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2732053002/20001
3 years, 9 months ago (2017-03-06 19:45:31 UTC) #7
commit-bot: I haz the power
3 years, 9 months ago (2017-03-06 20:46:48 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/a3923ce210c305fda4ec3f4d97f5a55f99e...

Powered by Google App Engine
This is Rietveld 408576698