Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issue 2732033002: Proof of concept of unity build for WebKit/Source/core/html (Closed)

Created:
3 years, 9 months ago by Daniel Bratell
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews, blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org, kinuko+watch, loading-reviews+parser_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Proof of concept of unity build for WebKit/Source/core/html For testing what effect you get from compiling all of the html folder in a single compilation unit. A few more cleanups were necessary but they have already landed as normal code cleanup on master. The only remaining code change is to prevent HTMLTokenizer.cpp from removing the DEFINE_STATIC_LOCAL macro which is also used by other code. The time change is CPU time going from 25.5 minutes to 1 minute for a compilation of all files in the folder.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+262 lines, -3 lines) Patch
M third_party/WebKit/Source/core/html/BUILD.gn View 3 chunks +7 lines, -3 lines 0 comments Download
A third_party/WebKit/Source/core/html/all_html_files.cpp View 1 chunk +252 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLTokenizer.cpp View 2 chunks +3 lines, -0 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698