Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1288)

Issue 2731953002: Don't double-resolve URL in TextTrackLoader::load (Closed)

Created:
3 years, 9 months ago by fs
Modified:
3 years, 9 months ago
Reviewers:
foolip
CC:
fs, blink-reviews, chromium-reviews, eric.carlson_apple.com, gasubic, nessy
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't double-resolve URL in TextTrackLoader::load The caller (HTMLTrackElement::loadTimerFired) will already have resolved the URL. BUG=466083 Review-Url: https://codereview.chromium.org/2731953002 Cr-Commit-Position: refs/heads/master@{#455050} Committed: https://chromium.googlesource.com/chromium/src/+/d36291af87cd567776f29534c3eb2b8d11581cfb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/core/loader/TextTrackLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
fs
3 years, 9 months ago (2017-03-06 12:10:39 UTC) #4
foolip
lgtm Confirmed that Element::getNonEmptyURLAttribute resolves the URL.
3 years, 9 months ago (2017-03-07 06:45:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2731953002/1
3 years, 9 months ago (2017-03-07 06:46:49 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-07 09:35:58 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d36291af87cd567776f29534c3eb...

Powered by Google App Engine
This is Rietveld 408576698