Move some content url constants to /url.

Move some content url constants to /url.

This CL moves the content url constants below to /url:
  content::kBlobScheme
  content::kDataScheme
  content::kFileScheme
  content::kFileSystemScheme
  content::kFtpScheme
  content::kJavaScriptScheme
  content::kMailToScheme

This is a follow up to https://codereview.chromium.org/254763005.

BUG=306258
TBR=finnur@chromium.org,mkosiba@chromium.org,derat@chromium.org
TEST=compile

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273359

[Sungmann Cho, 2014-05-10 02:04:49]

Please take a look. Thanks!

[Sungmann Cho, 2014-05-12 23:53:00]

+blundell: he is the reporter of this issue.

[blundell, 2014-05-13 08:02:46]

Moving darin and sky to CC

+abarth, jam: Can you review just the changes to
//content/public/common/url_constants* and //url/url_constants*?

Once John and Adam LGTM the moves of the constants then I'll run through the
whole review and Sungmann you can then TBR OWNERS for the usage site changes.

[jam, 2014-05-13 21:14:40]

content/public lgtm

please do go through the callers and make sure they're ordered correctly though

[blundell, 2014-05-19 07:41:21]

abarth@ to CC (I believe he's on leave)

+brettw for //url OWNERS. Brett, could you look at just
//content/public/common/url_constants.* and //url and LGTM if you're OK with the
constants being moved? I'll then review the whole CL.

[blundell, 2014-05-26 06:52:46]

brettw: ping

[brettw, 2014-05-26 19:01:19]

/url lgtm

[blundell, 2014-05-27 09:39:33]

https://codereview.chromium.org/273193004/diff/1/chrome/browser/autocomplete/...
File chrome/browser/autocomplete/autocomplete_input.cc (right):

https://codereview.chromium.org/273193004/diff/1/chrome/browser/autocomplete/...
chrome/browser/autocomplete/autocomplete_input.cc:12: #include
"content/public/common/url_constants.h"
Could you replace all of the includes of //content/public/common/url_constants.h
and //chome/common/url_constants.h with //url/url_constants.h whereever this is
feasible? The concrete benefit is that knowing at a glance which //chrome and
//content dependencies a given source file has is really useful for
componentization.

[Sungmann Cho, 2014-05-28 09:10:50]

https://codereview.chromium.org/273193004/diff/1/chrome/browser/autocomplete/...
File chrome/browser/autocomplete/autocomplete_input.cc (right):

https://codereview.chromium.org/273193004/diff/1/chrome/browser/autocomplete/...
chrome/browser/autocomplete/autocomplete_input.cc:12: #include
"content/public/common/url_constants.h"
On 2014/05/27 09:39:34, blundell wrote:
> Could you replace all of the includes of
//content/public/common/url_constants.h
> and //chome/common/url_constants.h with //url/url_constants.h whereever this
is
> feasible? The concrete benefit is that knowing at a glance which //chrome and
> //content dependencies a given source file has is really useful for
> componentization.

Done.

[blundell, 2014-05-28 11:21:47]

LGTM, thanks!

https://codereview.chromium.org/273193004/diff/40001/url/url_util.cc
File url/url_util.cc (right):

https://codereview.chromium.org/273193004/diff/40001/url/url_util.cc#newcode40
url/url_util.cc:40: url::kFileScheme,  // Yes, file urls can have a hostname!
nit: it looks like this code is already in the url namespace.

[Sungmann Cho, 2014-05-28 11:54:58]

Thank you for guiding me, blundell! :)

https://codereview.chromium.org/273193004/diff/40001/url/url_util.cc
File url/url_util.cc (right):

https://codereview.chromium.org/273193004/diff/40001/url/url_util.cc#newcode40
url/url_util.cc:40: url::kFileScheme,  // Yes, file urls can have a hostname!
On 2014/05/28 11:21:49, blundell wrote:
> nit: it looks like this code is already in the url namespace.

Done.

[Sungmann Cho, 2014-05-28 11:55:15]

The CQ bit was checked by sungmann.cho@navercorp.com

[commit-bot: I haz the power, 2014-05-28 11:55:51]

CQ is trying da patch. Follow status at

https://chromium-status.appspot.com/cq/sungmann.cho@navercorp.com/273193004/6...

[blundell, 2014-05-28 11:56:22]

note: make sure that you add any TBR'd engineers as reviewers and alert them to
what you're TBR'ing them for. Thanks!

[Sungmann Cho, 2014-05-28 12:06:24]

On 2014/05/28 11:56:22, blundell wrote:
> note: make sure that you add any TBR'd engineers as reviewers and alert them
to
> what you're TBR'ing them for. Thanks!

Got it! Thanks again!

[blundell, 2014-05-28 12:20:34]

sorry, one final nit:

When you add Finnur as a TBR'd reviewer, you should also send out a message
saying something like

"TBR=finnur for //foo/bar/baz" (I don't actually know what you're TBR'ing him
for in this case :)

It's all part of the learning curve :)

[Sungmann Cho, 2014-05-28 12:27:19]

TBR=finnur@ for //extensions

[Sungmann Cho, 2014-05-28 12:39:19]

On 2014/05/28 12:20:34, blundell wrote:
> sorry, one final nit:
> 
> When you add Finnur as a TBR'd reviewer, you should also send out a message
> saying something like
> 
> "TBR=finnur for //foo/bar/baz" (I don't actually know what you're TBR'ing him
> for in this case :)
> 
> It's all part of the learning curve :)

Actually, this is my first TBR'ing CL so it's a really valuable experience for
me. I learn something new everyday through reviews. Thanks again! :)

[Sungmann Cho, 2014-05-28 12:58:38]

The CQ bit was unchecked by sungmann.cho@navercorp.com

[Sungmann Cho, 2014-05-28 14:16:14]

+TBR=mkosiba@chromium.org for //android_webview
+TBR=derat@chromium.org for //apps

[Sungmann Cho, 2014-05-28 14:16:30]

The CQ bit was checked by sungmann.cho@navercorp.com

[commit-bot: I haz the power, 2014-05-28 14:17:45]

CQ is trying da patch. Follow status at

https://chromium-status.appspot.com/cq/sungmann.cho@navercorp.com/273193004/8...

[Daniel Erat, 2014-05-28 14:19:45]

lgtm for apps/shell

[mkosiba (inactive), 2014-05-28 15:54:21]

android_webview/ LGTM

[Finnur, 2014-05-28 16:33:23]

file:*extensions* LGTM

[Finnur, 2014-05-28 16:33:52]

On 2014/05/28 16:33:23, Finnur wrote:
> file:*extensions* LGTM

Well...

file:*extension*

.. technically.

[commit-bot: I haz the power, 2014-05-28 18:05:12]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-05-28 21:32:34]

Change committed as 273359