Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 254763005: Move some content url constants to /url. (Closed)

Created:
6 years, 8 months ago by Sungmann Cho
Modified:
6 years, 7 months ago
CC:
chromium-reviews, skanuj+watch_chromium.org, nkostylev+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, nasko+codewatch_chromium.org, browser-components-watch_chromium.org, markusheintz_, stevenjb+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, melevin+watch_chromium.org, benquan, Ilya Sherman, jam, dominich, darin-cc_chromium.org, rouslan+autofillwatch_chromium.org, chromium-apps-reviews_chromium.org, android-webview-reviews_chromium.org, creis+watch_chromium.org, dyu1, fischman+watch_chromium.org, dkrahn+watch_chromium.org, feature-media-reviews_chromium.org, jfweitz+watch_chromium.org, oshima+watch_chromium.org, estade+watch_chromium.org, Jered, chrome-apps-syd-reviews_chromium.org, tfarina, donnd+watch_chromium.org, mcasas+watch_chromium.org, David Black, Dane Wallinga, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, James Su, wjia+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Move some content url constants to /url. This CL moves the content::kHttpScheme and content::kHttpsScheme to /url. This is a follow up to https://codereview.chromium.org/25533005. BUG=306258 TEST=compile Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268782

Patch Set 1 : Initial patches. #

Total comments: 2

Patch Set 2 : Rebase and address some style nits. #

Total comments: 2

Patch Set 3 : Rebase and move url_constants.* to /url #

Patch Set 4 : Add some missing files. #

Total comments: 2

Patch Set 5 : Update url/BUILD.gn and address some style nits. #

Total comments: 2

Patch Set 6 : Remove duplicated inclusions of "url/url_constants.h". #

Patch Set 7 : Rebase #

Patch Set 8 : Resolve a merge conflict. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+161 lines, -140 lines) Patch
M android_webview/renderer/aw_content_renderer_client.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_input.cc View 1 2 3 4 5 6 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_match.cc View 1 2 3 4 5 6 7 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_provider.cc View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/autocomplete/base_search_provider.cc View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/autocomplete/history_url_provider.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/search_provider.cc View 1 2 3 4 5 6 3 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/autocomplete/zero_suggest_provider.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_helper_unittest.cc View 1 2 3 4 5 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/browsing_data/cookies_tree_model.cc View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/attestation/platform_verification_flow.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/content_settings/local_shared_objects_container.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/content_settings/content_settings_helpers.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/cookies/cookies_helpers.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/web_navigation/frame_navigation_state.cc View 1 2 3 4 5 1 chunk +8 lines, -8 lines 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_permissions.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/history/history_backend.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/history/in_memory_url_index.cc View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/history/url_database.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/history/visit_database.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/net/predictor_tab_helper.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/offline_resource_throttle.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/client_side_detection_host.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/database_manager.cc View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_blocking_page.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_test.cc View 1 2 3 4 5 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/search/search.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/template_url.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_parser.cc View 1 2 3 4 5 6 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/search_engines/template_url_service.cc View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/app_list/search/common/webservice_search_provider.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_browsertest.cc View 1 2 3 4 5 6 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/omnibox/omnibox_edit_model.cc View 1 2 3 4 5 6 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/search_engines/search_engine_tab_helper.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/web_applications/web_app.cc View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/web_resource/promo_resource_service_unittest.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/content_settings_helper.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/content_settings_pattern.cc View 1 2 3 4 5 6 4 chunks +10 lines, -10 lines 0 comments Download
M chrome/common/net/url_fixer_upper.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/search_urls.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/safe_browsing/phishing_classifier.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/utility/importer/ie_importer_win.cc View 1 2 3 4 5 2 chunks +4 lines, -4 lines 0 comments Download
M components/autofill/content/renderer/autofill_agent.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M content/browser/browser_url_handler_impl.cc View 1 2 3 4 5 6 1 chunk +7 lines, -7 lines 0 comments Download
M content/browser/child_process_security_policy_impl.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/child_process_security_policy_unittest.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/frame_host/navigation_controller_impl.cc View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/savable_url_schemes.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M content/plugin/webplugin_proxy.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/common/url_constants.h View 1 2 3 4 5 2 chunks +1 line, -2 lines 0 comments Download
M content/public/common/url_constants.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/media/buffered_data_source.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/buffered_data_source_unittest.cc View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/media/buffered_resource_loader.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_frame_impl.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/url_pattern.cc View 1 2 3 4 5 6 2 chunks +8 lines, -8 lines 0 comments Download
M extensions/renderer/dispatcher.cc View 1 2 3 4 5 6 1 chunk +5 lines, -2 lines 0 comments Download
M url/BUILD.gn View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
A url/url_constants.h View 1 2 3 1 chunk +17 lines, -0 lines 0 comments Download
A + url/url_constants.cc View 1 2 3 1 chunk +5 lines, -4 lines 0 comments Download
M url/url_srcs.gypi View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 38 (0 generated)
Sungmann Cho
This CL deals only with the named constants. I think we could remove the hardcoded ...
6 years, 8 months ago (2014-04-26 01:36:39 UTC) #1
blundell
LGTM, thanks! jam: fyi https://codereview.chromium.org/254763005/diff/1/chrome/browser/extensions/api/web_navigation/frame_navigation_state.cc File chrome/browser/extensions/api/web_navigation/frame_navigation_state.cc (right): https://codereview.chromium.org/254763005/diff/1/chrome/browser/extensions/api/web_navigation/frame_navigation_state.cc#newcode18 chrome/browser/extensions/api/web_navigation/frame_navigation_state.cc:18: content::kChromeUIScheme, net::kHttpScheme, nit: I prefer ...
6 years, 7 months ago (2014-04-28 09:11:15 UTC) #2
jochen (gone - plz use gerrit)
somebody from net/OWNERS should review as well
6 years, 7 months ago (2014-04-28 09:19:44 UTC) #3
Sungmann Cho
On 2014/04/28 09:11:15, blundell wrote: > LGTM, thanks! > > jam: fyi > > https://codereview.chromium.org/254763005/diff/1/chrome/browser/extensions/api/web_navigation/frame_navigation_state.cc ...
6 years, 7 months ago (2014-04-28 09:45:06 UTC) #4
blundell
I don't feel strongly about it.
6 years, 7 months ago (2014-04-28 09:45:46 UTC) #5
Sungmann Cho
On 2014/04/28 09:45:46, blundell wrote: > I don't feel strongly about it. OK. Then I'll ...
6 years, 7 months ago (2014-04-28 10:00:52 UTC) #6
Sungmann Cho
+David Benjamin for /net Please take a look. Thanks.
6 years, 7 months ago (2014-04-28 10:23:59 UTC) #7
davidben
Given GURL::SchemeIsHTTPOrHTTPS(), would it make more sense to push these up to url/ instead of ...
6 years, 7 months ago (2014-04-28 16:43:01 UTC) #8
abarth-chromium
https://codereview.chromium.org/254763005/diff/20001/net/base/url_constants.cc File net/base/url_constants.cc (right): https://codereview.chromium.org/254763005/diff/20001/net/base/url_constants.cc#newcode10 net/base/url_constants.cc:10: const char kHttpsScheme[] = "https"; Sure, we can move ...
6 years, 7 months ago (2014-04-28 17:59:49 UTC) #9
tfarina
https://codereview.chromium.org/254763005/diff/60001/url/url_srcs.gypi File url/url_srcs.gypi (right): https://codereview.chromium.org/254763005/diff/60001/url/url_srcs.gypi#newcode34 url/url_srcs.gypi:34: 'url_constants.cc', .cc before .h Please, also add these new ...
6 years, 7 months ago (2014-04-29 04:12:51 UTC) #10
Sungmann Cho
https://codereview.chromium.org/254763005/diff/1/chrome/browser/extensions/api/web_navigation/frame_navigation_state.cc File chrome/browser/extensions/api/web_navigation/frame_navigation_state.cc (right): https://codereview.chromium.org/254763005/diff/1/chrome/browser/extensions/api/web_navigation/frame_navigation_state.cc#newcode18 chrome/browser/extensions/api/web_navigation/frame_navigation_state.cc:18: content::kChromeUIScheme, net::kHttpScheme, On 2014/04/28 09:11:17, blundell wrote: > nit: ...
6 years, 7 months ago (2014-04-29 04:50:29 UTC) #11
jochen (gone - plz use gerrit)
lgtm with nit https://codereview.chromium.org/254763005/diff/80001/android_webview/renderer/aw_content_renderer_client.cc File android_webview/renderer/aw_content_renderer_client.cc (right): https://codereview.chromium.org/254763005/diff/80001/android_webview/renderer/aw_content_renderer_client.cc#newcode36 android_webview/renderer/aw_content_renderer_client.cc:36: #include "url/url_constants.h" instead of adding this ...
6 years, 7 months ago (2014-04-29 13:38:43 UTC) #12
Sungmann Cho
https://codereview.chromium.org/254763005/diff/80001/android_webview/renderer/aw_content_renderer_client.cc File android_webview/renderer/aw_content_renderer_client.cc (right): https://codereview.chromium.org/254763005/diff/80001/android_webview/renderer/aw_content_renderer_client.cc#newcode36 android_webview/renderer/aw_content_renderer_client.cc:36: #include "url/url_constants.h" On 2014/04/29 13:38:44, jochen (OOO Wed-Thu) wrote: ...
6 years, 7 months ago (2014-04-30 02:06:42 UTC) #13
Sungmann Cho
I submitted the revised patch. Please take a look.
6 years, 7 months ago (2014-04-30 17:28:18 UTC) #14
Sungmann Cho
ping...
6 years, 7 months ago (2014-05-01 20:52:46 UTC) #15
Evan Stade
On 2014/05/01 20:52:46, Sungmann Cho wrote: > ping... Jochen is out of office (OOO) but ...
6 years, 7 months ago (2014-05-01 20:56:51 UTC) #16
Sungmann Cho
On 2014/05/01 20:56:51, Evan Stade wrote: > On 2014/05/01 20:52:46, Sungmann Cho wrote: > > ...
6 years, 7 months ago (2014-05-01 21:44:42 UTC) #17
Sungmann Cho
The CQ bit was checked by sungmann.cho@navercorp.com
6 years, 7 months ago (2014-05-05 18:10:53 UTC) #18
Sungmann Cho
The CQ bit was unchecked by sungmann.cho@navercorp.com
6 years, 7 months ago (2014-05-05 18:11:07 UTC) #19
Sungmann Cho
ping...
6 years, 7 months ago (2014-05-06 02:50:05 UTC) #20
abarth-chromium
On 2014/05/06 02:50:05, Sungmann Cho wrote: > ping... Who are you pinging and for what?
6 years, 7 months ago (2014-05-06 04:24:46 UTC) #21
Sungmann Cho
On 2014/05/06 04:24:46, abarth wrote: > On 2014/05/06 02:50:05, Sungmann Cho wrote: > > ping... ...
6 years, 7 months ago (2014-05-06 06:34:40 UTC) #22
abarth-chromium
//url LGTM
6 years, 7 months ago (2014-05-06 17:42:30 UTC) #23
Sungmann Cho
The CQ bit was checked by sungmann.cho@navercorp.com
6 years, 7 months ago (2014-05-06 17:47:03 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sungmann.cho@navercorp.com/254763005/100001
6 years, 7 months ago (2014-05-06 17:48:00 UTC) #25
Sungmann Cho
The CQ bit was unchecked by sungmann.cho@navercorp.com
6 years, 7 months ago (2014-05-06 18:02:00 UTC) #26
Sungmann Cho
The CQ bit was checked by sungmann.cho@navercorp.com
6 years, 7 months ago (2014-05-06 19:11:56 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sungmann.cho@navercorp.com/254763005/120001
6 years, 7 months ago (2014-05-06 19:13:54 UTC) #28
Sungmann Cho
The CQ bit was unchecked by sungmann.cho@navercorp.com
6 years, 7 months ago (2014-05-06 19:35:31 UTC) #29
Sungmann Cho
+boliu for android_webview/renderer/* +kalman for extensions/* Please take a look. Thanks!
6 years, 7 months ago (2014-05-06 22:14:43 UTC) #30
not at google - send to devlin
lgtm
6 years, 7 months ago (2014-05-06 22:19:49 UTC) #31
boliu
android_webview lgtm
6 years, 7 months ago (2014-05-06 22:21:38 UTC) #32
Sungmann Cho
The CQ bit was checked by sungmann.cho@navercorp.com
6 years, 7 months ago (2014-05-06 22:23:12 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sungmann.cho@navercorp.com/254763005/140001
6 years, 7 months ago (2014-05-06 22:23:53 UTC) #34
Sungmann Cho
The CQ bit was unchecked by sungmann.cho@navercorp.com
6 years, 7 months ago (2014-05-07 12:00:33 UTC) #35
Sungmann Cho
The CQ bit was checked by sungmann.cho@navercorp.com
6 years, 7 months ago (2014-05-07 12:00:43 UTC) #36
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sungmann.cho@navercorp.com/254763005/140001
6 years, 7 months ago (2014-05-07 12:04:26 UTC) #37
commit-bot: I haz the power
6 years, 7 months ago (2014-05-07 15:31:24 UTC) #38
Message was sent while issue was closed. 
Change committed as 268782

Powered by Google App Engine
This is Rietveld 408576698