Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2731913004: [Chromecast] Update manifests to use content_packaged_services. (Closed)

Created:
3 years, 9 months ago by slan
Modified:
3 years, 9 months ago
Reviewers:
alokp
CC:
chromium-reviews, alokp+watch_chromium.org, lcwu+watch_chromium.org, halliwell+watch_chromium.org, Ken Rockot(use gerrit already)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromecast] Update manifests to use content_packaged_services. Since crrrev.com/2695803004, all services that don't require a BrowserContext should be packaged in |content_packaged_services|. Cast-specific services are all registered on this connector, so update each manifest and comments. BUG=649407 Test: cast_shell_internal_browsertest Review-Url: https://codereview.chromium.org/2731913004 Cr-Commit-Position: refs/heads/master@{#455270} Committed: https://chromium.googlesource.com/chromium/src/+/afc42ced3ccb6d8f6ce82ee7fe358ca299f28f9f

Patch Set 1 #

Patch Set 2 : Update stale comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -28 lines) Patch
M chromecast/browser/BUILD.gn View 1 2 chunks +27 lines, -25 lines 0 comments Download
M chromecast/browser/cast_browser_resources.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M chromecast/browser/cast_content_browser_client.cc View 1 chunk +7 lines, -3 lines 0 comments Download
A chromecast/browser/cast_content_packaged_services_manifest_overlay.json View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
slan
This is needed to build the most recent merge. Internal change: https://eureka-internal-review.git.corp.google.com/#/c/68876/
3 years, 9 months ago (2017-03-07 16:42:35 UTC) #2
slan
rockot to CC
3 years, 9 months ago (2017-03-07 16:43:46 UTC) #4
alokp
lgtm
3 years, 9 months ago (2017-03-07 18:57:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2731913004/20001
3 years, 9 months ago (2017-03-07 19:06:47 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-07 22:57:37 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/afc42ced3ccb6d8f6ce82ee7fe35...

Powered by Google App Engine
This is Rietveld 408576698