Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 2731913003: Remove FillDOMInThreatDetails finch feature. (Closed)

Created:
3 years, 9 months ago by lpz
Modified:
3 years, 9 months ago
Reviewers:
Jialiu Lin
CC:
chromium-reviews, grt+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove FillDOMInThreatDetails finch feature. This will begin collecting DOM hierarchy data in upcoming threat reports. The feature was initially just for safety but it's not needed to control the launch of populating the DOM field. BUG=674618 Review-Url: https://codereview.chromium.org/2731913003 Cr-Commit-Position: refs/heads/master@{#455774} Committed: https://chromium.googlesource.com/chromium/src/+/4358c39b82d2be186367a3280df1f115db642139

Patch Set 1 #

Patch Set 2 : Sync #

Patch Set 3 : Sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -18 lines) Patch
M chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/safe_browsing/threat_details.h View 1 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/safe_browsing/threat_details.cc View 1 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/safe_browsing/threat_details_unittest.cc View 1 3 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 22 (16 generated)
lpz
3 years, 9 months ago (2017-03-06 21:10:01 UTC) #3
Jialiu Lin
lgtm
3 years, 9 months ago (2017-03-06 21:18:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2731913003/20001
3 years, 9 months ago (2017-03-09 14:50:14 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/363889)
3 years, 9 months ago (2017-03-09 15:13:06 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2731913003/40001
3 years, 9 months ago (2017-03-09 16:14:21 UTC) #19
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 16:59:53 UTC) #22
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/4358c39b82d2be186367a3280df1...

Powered by Google App Engine
This is Rietveld 408576698