Add ShowLayoutOpportunityTree to NGLayoutOpportunityIterator

Add ShowLayoutOpportunityTree to NGLayoutOpportunityIterator

ShowLayoutOpportunityTree is used for debug purposes.

BUG=635619
Review-Url: https://codereview.chromium.org/2731893003
Cr-Commit-Position: refs/heads/master@{#455400}
Committed: https://chromium.googlesource.com/chromium/src/+/71cf4c57d32ff6e31adf1d5cfd0182b8132a727a

[Gleb Lanbin, 2017-03-06 19:22:16]

glebl@chromium.org changed reviewers:
+ ikilpatrick@chromium.org

[Gleb Lanbin, 2017-03-06 19:22:22]

The CQ bit was checked by glebl@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-06 19:22:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ikilpatrick, 2017-03-06 19:26:36]

lgtm

[cbiesinger, 2017-03-06 19:56:01]

cbiesinger@chromium.org changed reviewers:
+ cbiesinger@chromium.org

[cbiesinger, 2017-03-06 19:56:02]

https://codereview.chromium.org/2731893003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.h
(right):

https://codereview.chromium.org/2731893003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.h:44:
void ShowLayoutOpportunityTree() const;
Consider putting this in #ifndef NDEBUG like showLayoutTreeForThis()?

[commit-bot: I haz the power, 2017-03-06 20:55:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-06 20:55:41]

Dry run: This issue passed the CQ dry run.

[Gleb Lanbin, 2017-03-06 21:08:10]

thanks for the review

https://codereview.chromium.org/2731893003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.h
(right):

https://codereview.chromium.org/2731893003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.h:44:
void ShowLayoutOpportunityTree() const;
On 2017/03/06 19:56:02, cbiesinger wrote:
> Consider putting this in #ifndef NDEBUG like showLayoutTreeForThis()?

Done.

[Gleb Lanbin, 2017-03-06 21:08:26]

The CQ bit was checked by glebl@chromium.org

[Gleb Lanbin, 2017-03-06 21:08:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
ikilpatrick@chromium.org
Link to the patchset: https://codereview.chromium.org/2731893003/#ps20001
(title: "fix comments")

[commit-bot: I haz the power, 2017-03-06 21:09:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 01:14:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 01:14:46]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Gleb Lanbin, 2017-03-07 01:15:43]

The CQ bit was checked by glebl@chromium.org

[commit-bot: I haz the power, 2017-03-07 01:16:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 04:42:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 04:42:01]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Gleb Lanbin, 2017-03-07 04:42:36]

The CQ bit was checked by glebl@chromium.org

[commit-bot: I haz the power, 2017-03-07 04:43:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 08:17:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 08:17:39]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Gleb Lanbin, 2017-03-07 15:46:30]

The CQ bit was checked by glebl@chromium.org

[commit-bot: I haz the power, 2017-03-07 15:47:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[cbiesinger, 2017-03-07 19:11:27]

lgtm

[commit-bot: I haz the power, 2017-03-07 19:56:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 19:56:37]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Gleb Lanbin, 2017-03-07 20:26:33]

The CQ bit was checked by glebl@chromium.org

[commit-bot: I haz the power, 2017-03-07 20:27:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 00:00:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 00:00:35]

Failed to apply patch for
third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.cc:
While running git apply --index -p1;
  error: patch failed:
third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.cc:6
  error:
third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.cc:
patch does not apply

Patch:      
third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.cc
Index:
third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.cc
diff --git
a/third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.cc
b/third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.cc
index
b04dc468c1a84e2540659cd76719c3487e23a2ff..fc9720fe63a90ea86631def28b28eb7430dc7c32
100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.cc
+++ b/third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.cc
@@ -6,10 +6,41 @@
 
 #include "core/layout/ng/ng_exclusion.h"
 #include "wtf/NonCopyingSort.h"
+#include "wtf/text/StringBuilder.h"
 
 namespace blink {
 namespace {
 
+void AppendNodeToString(const NGLayoutOpportunityTreeNode* node,
+                        StringBuilder* string_builder,
+                        unsigned indent = 0) {
+  DCHECK(string_builder);
+  if (!node) {
+    string_builder->append("'null'\n");
+    return;
+  }
+
+  string_builder->append(node->ToString());
+  string_builder->append("\n");
+
+  StringBuilder indent_builder;
+  for (unsigned i = 0; i < indent; i++)
+    indent_builder.append("\t");
+
+  if (!node->exclusion)
+    return;
+
+  string_builder->append(indent_builder.toString());
+  string_builder->append("Left:\t");
+  AppendNodeToString(node->left, string_builder, indent + 2);
+  string_builder->append(indent_builder.toString());
+  string_builder->append("Right:\t");
+  AppendNodeToString(node->right, string_builder, indent + 2);
+  string_builder->append(indent_builder.toString());
+  string_builder->append("Bottom:\t");
+  AppendNodeToString(node->bottom, string_builder, indent + 2);
+}
+
 // Collects all opportunities from leaves of Layout Opportunity spatial tree.
 void CollectAllOpportunities(const NGLayoutOpportunityTreeNode* node,
                              NGLayoutOpportunities& opportunities) {
@@ -275,4 +306,13 @@ const NGLayoutOpportunity
NGLayoutOpportunityIterator::Next() {
   return NGLayoutOpportunity(*opportunity);
 }
 
+#ifndef NDEBUG
+void NGLayoutOpportunityIterator::ShowLayoutOpportunityTree() const {
+  StringBuilder string_builder;
+  string_builder.append("\n.:: LayoutOpportunity Tree ::.\n\nRoot Node: ");
+  AppendNodeToString(opportunity_tree_root_.get(), &string_builder);
+  fprintf(stderr, "%s\n", string_builder.toString().utf8().data());
+}
+#endif
+
 }  // namespace blink

[Gleb Lanbin, 2017-03-08 00:11:13]

The CQ bit was checked by glebl@chromium.org

[commit-bot: I haz the power, 2017-03-08 00:11:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 00:17:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 00:17:19]

Failed to apply patch for
third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.cc:
While running git apply --index -p1;
  error: patch failed:
third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.cc:6
  error:
third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.cc:
patch does not apply

Patch:      
third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.cc
Index:
third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.cc
diff --git
a/third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.cc
b/third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.cc
index
b04dc468c1a84e2540659cd76719c3487e23a2ff..fc9720fe63a90ea86631def28b28eb7430dc7c32
100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.cc
+++ b/third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.cc
@@ -6,10 +6,41 @@
 
 #include "core/layout/ng/ng_exclusion.h"
 #include "wtf/NonCopyingSort.h"
+#include "wtf/text/StringBuilder.h"
 
 namespace blink {
 namespace {
 
+void AppendNodeToString(const NGLayoutOpportunityTreeNode* node,
+                        StringBuilder* string_builder,
+                        unsigned indent = 0) {
+  DCHECK(string_builder);
+  if (!node) {
+    string_builder->append("'null'\n");
+    return;
+  }
+
+  string_builder->append(node->ToString());
+  string_builder->append("\n");
+
+  StringBuilder indent_builder;
+  for (unsigned i = 0; i < indent; i++)
+    indent_builder.append("\t");
+
+  if (!node->exclusion)
+    return;
+
+  string_builder->append(indent_builder.toString());
+  string_builder->append("Left:\t");
+  AppendNodeToString(node->left, string_builder, indent + 2);
+  string_builder->append(indent_builder.toString());
+  string_builder->append("Right:\t");
+  AppendNodeToString(node->right, string_builder, indent + 2);
+  string_builder->append(indent_builder.toString());
+  string_builder->append("Bottom:\t");
+  AppendNodeToString(node->bottom, string_builder, indent + 2);
+}
+
 // Collects all opportunities from leaves of Layout Opportunity spatial tree.
 void CollectAllOpportunities(const NGLayoutOpportunityTreeNode* node,
                              NGLayoutOpportunities& opportunities) {
@@ -275,4 +306,13 @@ const NGLayoutOpportunity
NGLayoutOpportunityIterator::Next() {
   return NGLayoutOpportunity(*opportunity);
 }
 
+#ifndef NDEBUG
+void NGLayoutOpportunityIterator::ShowLayoutOpportunityTree() const {
+  StringBuilder string_builder;
+  string_builder.append("\n.:: LayoutOpportunity Tree ::.\n\nRoot Node: ");
+  AppendNodeToString(opportunity_tree_root_.get(), &string_builder);
+  fprintf(stderr, "%s\n", string_builder.toString().utf8().data());
+}
+#endif
+
 }  // namespace blink

[Gleb Lanbin, 2017-03-08 00:27:06]

The CQ bit was checked by glebl@chromium.org

[Gleb Lanbin, 2017-03-08 00:27:06]

The patchset sent to the CQ was uploaded after l-g-t-m from
cbiesinger@chromium.org, ikilpatrick@chromium.org
Link to the patchset: https://codereview.chromium.org/2731893003/#ps40001
(title: "git rebase-update")

[commit-bot: I haz the power, 2017-03-08 00:28:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 01:21:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 01:21:12]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Gleb Lanbin, 2017-03-08 01:41:26]

The CQ bit was checked by glebl@chromium.org

[commit-bot: I haz the power, 2017-03-08 01:42:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 02:37:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 02:37:29]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Gleb Lanbin, 2017-03-08 03:27:16]

The CQ bit was checked by glebl@chromium.org

[commit-bot: I haz the power, 2017-03-08 03:27:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 03:59:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 03:59:32]

Failed to apply patch for
third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.cc:
While running git apply --index -p1;
  error: patch failed:
third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.cc:6
  error:
third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.cc:
patch does not apply

Patch:      
third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.cc
Index:
third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.cc
diff --git
a/third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.cc
b/third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.cc
index
b04dc468c1a84e2540659cd76719c3487e23a2ff..fc9720fe63a90ea86631def28b28eb7430dc7c32
100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.cc
+++ b/third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.cc
@@ -6,10 +6,41 @@
 
 #include "core/layout/ng/ng_exclusion.h"
 #include "wtf/NonCopyingSort.h"
+#include "wtf/text/StringBuilder.h"
 
 namespace blink {
 namespace {
 
+void AppendNodeToString(const NGLayoutOpportunityTreeNode* node,
+                        StringBuilder* string_builder,
+                        unsigned indent = 0) {
+  DCHECK(string_builder);
+  if (!node) {
+    string_builder->append("'null'\n");
+    return;
+  }
+
+  string_builder->append(node->ToString());
+  string_builder->append("\n");
+
+  StringBuilder indent_builder;
+  for (unsigned i = 0; i < indent; i++)
+    indent_builder.append("\t");
+
+  if (!node->exclusion)
+    return;
+
+  string_builder->append(indent_builder.toString());
+  string_builder->append("Left:\t");
+  AppendNodeToString(node->left, string_builder, indent + 2);
+  string_builder->append(indent_builder.toString());
+  string_builder->append("Right:\t");
+  AppendNodeToString(node->right, string_builder, indent + 2);
+  string_builder->append(indent_builder.toString());
+  string_builder->append("Bottom:\t");
+  AppendNodeToString(node->bottom, string_builder, indent + 2);
+}
+
 // Collects all opportunities from leaves of Layout Opportunity spatial tree.
 void CollectAllOpportunities(const NGLayoutOpportunityTreeNode* node,
                              NGLayoutOpportunities& opportunities) {
@@ -275,4 +306,13 @@ const NGLayoutOpportunity
NGLayoutOpportunityIterator::Next() {
   return NGLayoutOpportunity(*opportunity);
 }
 
+#ifndef NDEBUG
+void NGLayoutOpportunityIterator::ShowLayoutOpportunityTree() const {
+  StringBuilder string_builder;
+  string_builder.append("\n.:: LayoutOpportunity Tree ::.\n\nRoot Node: ");
+  AppendNodeToString(opportunity_tree_root_.get(), &string_builder);
+  fprintf(stderr, "%s\n", string_builder.toString().utf8().data());
+}
+#endif
+
 }  // namespace blink

[Gleb Lanbin, 2017-03-08 04:03:05]

The CQ bit was checked by glebl@chromium.org

[commit-bot: I haz the power, 2017-03-08 04:03:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 04:08:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 04:08:22]

Failed to apply patch for
third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.cc:
While running git apply --index -p1;
  error: patch failed:
third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.cc:6
  error:
third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.cc:
patch does not apply

Patch:      
third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.cc
Index:
third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.cc
diff --git
a/third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.cc
b/third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.cc
index
b04dc468c1a84e2540659cd76719c3487e23a2ff..fc9720fe63a90ea86631def28b28eb7430dc7c32
100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.cc
+++ b/third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.cc
@@ -6,10 +6,41 @@
 
 #include "core/layout/ng/ng_exclusion.h"
 #include "wtf/NonCopyingSort.h"
+#include "wtf/text/StringBuilder.h"
 
 namespace blink {
 namespace {
 
+void AppendNodeToString(const NGLayoutOpportunityTreeNode* node,
+                        StringBuilder* string_builder,
+                        unsigned indent = 0) {
+  DCHECK(string_builder);
+  if (!node) {
+    string_builder->append("'null'\n");
+    return;
+  }
+
+  string_builder->append(node->ToString());
+  string_builder->append("\n");
+
+  StringBuilder indent_builder;
+  for (unsigned i = 0; i < indent; i++)
+    indent_builder.append("\t");
+
+  if (!node->exclusion)
+    return;
+
+  string_builder->append(indent_builder.toString());
+  string_builder->append("Left:\t");
+  AppendNodeToString(node->left, string_builder, indent + 2);
+  string_builder->append(indent_builder.toString());
+  string_builder->append("Right:\t");
+  AppendNodeToString(node->right, string_builder, indent + 2);
+  string_builder->append(indent_builder.toString());
+  string_builder->append("Bottom:\t");
+  AppendNodeToString(node->bottom, string_builder, indent + 2);
+}
+
 // Collects all opportunities from leaves of Layout Opportunity spatial tree.
 void CollectAllOpportunities(const NGLayoutOpportunityTreeNode* node,
                              NGLayoutOpportunities& opportunities) {
@@ -275,4 +306,13 @@ const NGLayoutOpportunity
NGLayoutOpportunityIterator::Next() {
   return NGLayoutOpportunity(*opportunity);
 }
 
+#ifndef NDEBUG
+void NGLayoutOpportunityIterator::ShowLayoutOpportunityTree() const {
+  StringBuilder string_builder;
+  string_builder.append("\n.:: LayoutOpportunity Tree ::.\n\nRoot Node: ");
+  AppendNodeToString(opportunity_tree_root_.get(), &string_builder);
+  fprintf(stderr, "%s\n", string_builder.toString().utf8().data());
+}
+#endif
+
 }  // namespace blink

[Gleb Lanbin, 2017-03-08 04:33:45]

The CQ bit was checked by glebl@chromium.org

[Gleb Lanbin, 2017-03-08 04:33:46]

The patchset sent to the CQ was uploaded after l-g-t-m from
cbiesinger@chromium.org, ikilpatrick@chromium.org
Link to the patchset: https://codereview.chromium.org/2731893003/#ps60001
(title: "git rebase v2")

[commit-bot: I haz the power, 2017-03-08 04:33:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 04:35:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 04:35:26]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Gleb Lanbin, 2017-03-08 04:54:44]

The CQ bit was checked by glebl@chromium.org

[commit-bot: I haz the power, 2017-03-08 04:54:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 05:35:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 05:35:57]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Gleb Lanbin, 2017-03-08 05:50:56]

The CQ bit was checked by glebl@chromium.org

[commit-bot: I haz the power, 2017-03-08 05:51:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 06:48:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 06:48:40]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Gleb Lanbin, 2017-03-08 06:49:31]

The CQ bit was checked by glebl@chromium.org

[commit-bot: I haz the power, 2017-03-08 06:49:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 08:27:13]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1488955771096350,
"parent_rev": "97b851195835fc2e6dfc60e1e05e770425e4df6e", "commit_rev":
"71cf4c57d32ff6e31adf1d5cfd0182b8132a727a"}

[commit-bot: I haz the power, 2017-03-08 08:27:57]

Description was changed from

==========
Add ShowLayoutOpportunityTree to NGLayoutOpportunityIterator

ShowLayoutOpportunityTree is used for debug purposes.

BUG=635619
==========

to

==========
Add ShowLayoutOpportunityTree to NGLayoutOpportunityIterator

ShowLayoutOpportunityTree is used for debug purposes.

BUG=635619

Review-Url: https://codereview.chromium.org/2731893003
Cr-Commit-Position: refs/heads/master@{#455400}
Committed:
https://chromium.googlesource.com/chromium/src/+/71cf4c57d32ff6e31adf1d5cfd01...
==========

[commit-bot: I haz the power, 2017-03-08 08:27:59]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/71cf4c57d32ff6e31adf1d5cfd01...