Issue 2731883002: mediaview: Support watchers in ArcDocumentsProviderRoot.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2731883002: mediaview: Support watchers in ArcDocumentsProviderRoot. (Closed)

Created:
3 years, 9 months ago by Shuhei Takahashi

Modified:
3 years, 9 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/3029

Project:
chromium

Visibility:
Public.

mediaview: Support watchers in ArcDocumentsProviderRoot. Watchers are not always correct by design. See the long comments at AddWatcher(). BUG=chromium:684233 TEST=trybot Review-Url: https://codereview.chromium.org/2715473003 Cr-Commit-Position: refs/heads/master@{#454590} (cherry picked from commit 7049abb88b1e21acdd6345400183cd1df7762a84) Review-Url: https://codereview.chromium.org/2731883002 . Cr-Commit-Position: refs/branch-heads/3029@{#13} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/c700fa7ae3641919406e695b2a393d7691ca2086

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+291 lines, -3 lines)			Patch
M	chrome/browser/chromeos/arc/fileapi/arc_documents_provider_root.h	View	7 chunks	+94 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/arc/fileapi/arc_documents_provider_root.cc	View	5 chunks	+105 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/arc/fileapi/arc_documents_provider_root_unittest.cc	View	3 chunks	+92 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

Shuhei Takahashi

3 years, 9 months ago (2017-03-06 03:33:43 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c700fa7ae3641919406e695b2a393d7691ca2086.