move comment tokens into preceedingComments field

move comment tokens into preceedingComments field

Fix https://github.com/dart-lang/sdk/issues/28850

R=paulberry@google.com

Committed: https://github.com/dart-lang/sdk/commit/69ad5c37a13239d8277a9aa161cf4f7a544e8b4d

[danrubel, 2017-03-05 17:48:28]

danrubel@google.com changed reviewers:
+ ahe@google.com, paulberry@google.com

[danrubel, 2017-03-05 17:48:29]

Per https://github.com/dart-lang/sdk/issues/28850, this moves comment tokens out
of the main token stream into the Token.preceedingComment field.

[Paul Berry, 2017-03-06 14:06:50]

lgtm

https://codereview.chromium.org/2731863002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/scanner/array_based_scanner.dart (right):

https://codereview.chromium.org/2731863002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/scanner/array_based_scanner.dart:243: * Returns a
new substring from the scan offset [:start:] to the current
Nit: I've always seen this written as `[start]` rather than `[:start:]`.  Is
this a new notation or a mistake?  If it's new, what does it mean and where is
its behavior defined?

[danrubel, 2017-03-06 19:50:29]

https://codereview.chromium.org/2731863002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/scanner/array_based_scanner.dart (right):

https://codereview.chromium.org/2731863002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/scanner/array_based_scanner.dart:243: * Returns a
new substring from the scan offset [:start:] to the current
On 2017/03/06 14:06:50, Paul Berry wrote:
> Nit: I've always seen this written as `[start]` rather than `[:start:]`.  Is
> this a new notation or a mistake?  If it's new, what does it mean and where is
> its behavior defined?

This is cribbed from appendSubstringToken. I think "[:" is a holdover from
earlier Dart days. Removed ":".

[danrubel, 2017-03-06 23:28:08]

PTAL. Updated fasta <--> analyzer token translation

[Paul Berry, 2017-03-07 13:55:54]

lgtm

[ahe, 2017-03-07 14:06:40]

I'd like to be sure that this doesn't harm performance before we land it.

[danrubel, 2017-03-07 17:50:39]

Description was changed from

==========
move comment tokens into preceedingComments field

Fix https://github.com/dart-lang/sdk/issues/28850
==========

to

==========
move comment tokens into preceedingComments field

Fix https://github.com/dart-lang/sdk/issues/28850

R=paulberry@google.com

Committed:
https://github.com/dart-lang/sdk/commit/69ad5c37a13239d8277a9aa161cf4f7a544e8b4d
==========

[danrubel, 2017-03-07 17:50:41]

Committed patchset #4 (id:60001) manually as
69ad5c37a13239d8277a9aa161cf4f7a544e8b4d (presubmit successful).