Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(711)

Unified Diff: pkg/front_end/lib/src/fasta/scanner/utf8_bytes_scanner.dart

Issue 2731863002: move comment tokens into preceedingComments field (Closed)
Patch Set: merge Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/front_end/lib/src/fasta/scanner/token.dart ('k') | pkg/front_end/test/scanner_fasta_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/front_end/lib/src/fasta/scanner/utf8_bytes_scanner.dart
diff --git a/pkg/front_end/lib/src/fasta/scanner/utf8_bytes_scanner.dart b/pkg/front_end/lib/src/fasta/scanner/utf8_bytes_scanner.dart
index ca004ed5d38b549637bf81bdaf5a922e04efd87d..84ae1554d696d7e82606a5f1518642b0dface19e 100644
--- a/pkg/front_end/lib/src/fasta/scanner/utf8_bytes_scanner.dart
+++ b/pkg/front_end/lib/src/fasta/scanner/utf8_bytes_scanner.dart
@@ -198,11 +198,12 @@ class Utf8BytesScanner extends ArrayBasedScanner {
Token firstToken() => tokens.next;
Token previousToken() => tail;
- void appendSubstringToken(PrecedenceInfo info, int start, bool asciiOnly,
+ @override
+ StringToken createSubstringToken(
+ PrecedenceInfo info, int start, bool asciiOnly,
[int extraOffset = 0]) {
- tail.next = new StringToken.fromUtf8Bytes(
+ return new StringToken.fromUtf8Bytes(
info, bytes, start, byteOffset + extraOffset, asciiOnly, tokenStart);
- tail = tail.next;
}
bool atEndOfFile() => byteOffset >= bytes.length - 1;
« no previous file with comments | « pkg/front_end/lib/src/fasta/scanner/token.dart ('k') | pkg/front_end/test/scanner_fasta_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698