Replace use of logging::DEBUG_MODE with DCHECK_IS_ON().

Replace use of logging::DEBUG_MODE with DCHECK_IS_ON().

DEBUG_MODE was originally provided to allow code of the form:

  if (DEBUG_MODE) { ... }

rather than preprocessor conditional (i.e. #ifdef _DEBUG), while
still ensuring that the condition was static at compile-time, allowing
the affected code to be trivially optimized-out.

The function-like macro DCHECK_IS_ON(), added to simplify conditional
compilation of DCHECK-related code when DCHECK_ALWAYS_ON was added, can
now be used safely for both preprocessor and C++ conditionals in place of
DEBUG_MODE.

Review-Url: https://codereview.chromium.org/2731823002
Cr-Commit-Position: refs/heads/master@{#456519}
Committed: https://chromium.googlesource.com/chromium/src/+/8ccfd32a69c3e1c2ad8ca5f3b8f806796854ad52

[Wez, 2017-03-12 00:11:11]

Description was changed from

==========
Replace use of logging::DEBUG_MODE with DCHECK_IS_ON().

BUG=
==========

to

==========
Replace use of logging::DEBUG_MODE with DCHECK_IS_ON().
==========

[Wez, 2017-03-12 00:14:09]

wez@chromium.org changed reviewers:
+ dcheng@chromium.org

[Wez, 2017-03-12 00:14:09]

PTAL :)

[Wez, 2017-03-12 00:17:29]

The CQ bit was checked by wez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-12 00:17:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-12 02:00:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-12 02:00:16]

Dry run: This issue passed the CQ dry run.

[dcheng, 2017-03-12 02:36:39]

This seems relatively straightforward to me, but is there any historical context
on why this was even configured as an enumerator value?

[dcheng, 2017-03-12 02:37:18]

(If there is, it'd be nice to include it in the CL description. Other than that,
LGTM)

[Wez, 2017-03-12 21:59:48]

DEBUG_MODE was in there since base/logging.h was first landed (see
https://chromium.googlesource.com/chromium/src/+/d7cae12696b96500c05dd2d430f6...
).

My guess would be that the idea was to provide a conditional equivalent to
the _DEBUG macro, and for that to still be optimized-out at compile time,
hence the need for an enum rather than a const bool; the DCHECK_IS_ON()
macro serves that use-case now.

On 11 March 2017 at 18:37, <dcheng@chromium.org> wrote:

> (If there is, it'd be nice to include it in the CL description. Other than
> that,
> LGTM)
>
> https://codereview.chromium.org/2731823002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Wez, 2017-03-12 22:24:55]

Description was changed from

==========
Replace use of logging::DEBUG_MODE with DCHECK_IS_ON().
==========

to

==========
Replace use of logging::DEBUG_MODE with DCHECK_IS_ON().

DEBUG_MODE was originally provided to allow code of the form:

  if (DEBUG_MODE) { ... }

rather than preprocessor conditional (i.e. #ifdef _DEBUG), while
still ensuring that the condition was static at compile-time, allowing
the affected code to be trivially optimized-out.

The function-like macro DCHECK_IS_ON(), added to simplify conditional
compilation of DCHECK-related code when DCHECK_ALWAYS_ON was added, can
now be used safely for both preprocessor and C++ conditionals in place of
DEBUG_MODE.
==========

[Wez, 2017-03-12 22:25:06]

The CQ bit was checked by wez@chromium.org

[commit-bot: I haz the power, 2017-03-12 22:25:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-12 22:31:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-12 22:31:46]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Wez, 2017-03-12 23:05:24]

wez@chromium.org changed reviewers:
+ rsleevi@chromium.org, zea@chromium.org

[Wez, 2017-03-12 23:05:24]

rsleevi: crypto/ plz
zea: components/sync/ plz

[Ryan Sleevi, 2017-03-13 13:35:06]

lgtm

[Nicolas Zea, 2017-03-13 19:48:40]

lgtm

[Wez, 2017-03-13 20:17:41]

The CQ bit was checked by wez@chromium.org

[commit-bot: I haz the power, 2017-03-13 20:18:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-13 22:54:33]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1489436261978470, "parent_rev":
"2fb4f2c9c461551d43fdfa28ef4c960da81a47dd", "commit_rev":
"8ccfd32a69c3e1c2ad8ca5f3b8f806796854ad52"}

[commit-bot: I haz the power, 2017-03-13 22:55:13]

Description was changed from

==========
Replace use of logging::DEBUG_MODE with DCHECK_IS_ON().

DEBUG_MODE was originally provided to allow code of the form:

  if (DEBUG_MODE) { ... }

rather than preprocessor conditional (i.e. #ifdef _DEBUG), while
still ensuring that the condition was static at compile-time, allowing
the affected code to be trivially optimized-out.

The function-like macro DCHECK_IS_ON(), added to simplify conditional
compilation of DCHECK-related code when DCHECK_ALWAYS_ON was added, can
now be used safely for both preprocessor and C++ conditionals in place of
DEBUG_MODE.
==========

to

==========
Replace use of logging::DEBUG_MODE with DCHECK_IS_ON().

DEBUG_MODE was originally provided to allow code of the form:

  if (DEBUG_MODE) { ... }

rather than preprocessor conditional (i.e. #ifdef _DEBUG), while
still ensuring that the condition was static at compile-time, allowing
the affected code to be trivially optimized-out.

The function-like macro DCHECK_IS_ON(), added to simplify conditional
compilation of DCHECK-related code when DCHECK_ALWAYS_ON was added, can
now be used safely for both preprocessor and C++ conditionals in place of
DEBUG_MODE.

Review-Url: https://codereview.chromium.org/2731823002
Cr-Commit-Position: refs/heads/master@{#456519}
Committed:
https://chromium.googlesource.com/chromium/src/+/8ccfd32a69c3e1c2ad8ca5f3b8f8...
==========

[commit-bot: I haz the power, 2017-03-13 22:55:15]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8ccfd32a69c3e1c2ad8ca5f3b8f8...