content/browser should depend on webrtc_overrides:init_webrtc

content/browser should depend on webrtc_overrides:init_webrtc

BlankDetectorDesktopCapturerWrapper needs to use HISTOGRAM in its
implementation. So content/browser needs to depend on init_webrtc target to get
histogram required components to be built in.
This should fix https://codereview.chromium.org/2709523003/ and
https://codereview.chromium.org/2725143004/.

BUG=682112
Review-Url: https://codereview.chromium.org/2731803002
Cr-Commit-Position: refs/heads/master@{#489442}
Committed: https://chromium.googlesource.com/chromium/src/+/96d6987c5d68575b222ba9028802d47b889fd658

[Hzj_jie, 2017-03-04 02:23:36]

The CQ bit was checked by zijiehe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-04 02:23:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Hzj_jie, 2017-03-04 02:30:50]

Description was changed from

==========
content/browser should depend on webrtc_overrides:init_webrtc

BlankDetectorDesktopCapturerWrapper needs to use HISTOGRAM in its
implementation. So content/browser needs to depend on init_webrtc target to get
histogram required components to be built in.

BUG=682112
==========

to

==========
content/browser should depend on webrtc_overrides:init_webrtc

BlankDetectorDesktopCapturerWrapper needs to use HISTOGRAM in its
implementation. So content/browser needs to depend on init_webrtc target to get
histogram required components to be built in.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng

BUG=682112
==========

[Hzj_jie, 2017-03-04 02:31:12]

Description was changed from

==========
content/browser should depend on webrtc_overrides:init_webrtc

BlankDetectorDesktopCapturerWrapper needs to use HISTOGRAM in its
implementation. So content/browser needs to depend on init_webrtc target to get
histogram required components to be built in.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng

BUG=682112
==========

to

==========
content/browser should depend on webrtc_overrides:init_webrtc

BlankDetectorDesktopCapturerWrapper needs to use HISTOGRAM in its
implementation. So content/browser needs to depend on init_webrtc target to get
histogram required components to be built in.

BUG=682112
==========

[Hzj_jie, 2017-03-04 02:34:10]

The CQ bit was checked by zijiehe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-04 02:34:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Hzj_jie, 2017-03-04 02:34:25]

Patchset #1 (id:1) has been deleted

[Hzj_jie, 2017-03-04 03:36:55]

Description was changed from

==========
content/browser should depend on webrtc_overrides:init_webrtc

BlankDetectorDesktopCapturerWrapper needs to use HISTOGRAM in its
implementation. So content/browser needs to depend on init_webrtc target to get
histogram required components to be built in.

BUG=682112
==========

to

==========
content/browser should depend on webrtc_overrides:init_webrtc

BlankDetectorDesktopCapturerWrapper needs to use HISTOGRAM in its
implementation. So content/browser needs to depend on init_webrtc target to get
histogram required components to be built in.
This should fix https://codereview.chromium.org/2709523003/.

BUG=682112
==========

[Hzj_jie, 2017-03-04 03:36:55]

zijiehe@chromium.org changed reviewers:
+ perkj@webrtc.org

[commit-bot: I haz the power, 2017-03-04 03:56:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-04 03:56:50]

Dry run: This issue passed the CQ dry run.

[Hzj_jie, 2017-03-05 19:48:50]

Description was changed from

==========
content/browser should depend on webrtc_overrides:init_webrtc

BlankDetectorDesktopCapturerWrapper needs to use HISTOGRAM in its
implementation. So content/browser needs to depend on init_webrtc target to get
histogram required components to be built in.
This should fix https://codereview.chromium.org/2709523003/.

BUG=682112
==========

to

==========
content/browser should depend on webrtc_overrides:init_webrtc

BlankDetectorDesktopCapturerWrapper needs to use HISTOGRAM in its
implementation. So content/browser needs to depend on init_webrtc target to get
histogram required components to be built in.
This should fix https://codereview.chromium.org/2709523003/ and
https://codereview.chromium.org/2725143004/.

BUG=682112
==========

[Hzj_jie, 2017-03-05 19:50:02]

Per, I believe this change can resolve
https://codereview.chromium.org/2725143004/, i.e. HISTOGRAM is not linked with
Chrome. But would you mind to give me some hints, how could I verify this change
before submitting it?

[perkj_chrome, 2017-03-06 08:06:54]

On 2017/03/05 19:50:02, Hzj_jie wrote:
> Per, I believe this change can resolve
> https://codereview.chromium.org/2725143004/, i.e. HISTOGRAM is not linked with
> Chrome. But would you mind to give me some hints, how could I verify this
change
> before submitting it?

Since you have landed the depending cl you can enter third_party/webrtc and do
git pull, then git log and find the your cl and git checkout the cl commit and
then build chrome locally.

[perkj_chrome, 2017-03-06 08:11:07]

perkj@chromium.org changed reviewers:
+ perkj@chromium.org

[perkj_chrome, 2017-03-06 08:11:07]

lgtm

[Hzj_jie, 2017-03-07 00:31:20]

On 2017/03/06 08:11:07, perkj_chrome wrote:
> lgtm

Thank you Per. So I will try to change WebRTC folder in a Chromium enlistment,
and to ensure this change actually helps before submitting.

[Hzj_jie, 2017-03-07 03:10:52]

On 2017/03/07 00:31:20, Hzj_jie wrote:
> On 2017/03/06 08:11:07, perkj_chrome wrote:
> > lgtm
> 
> Thank you Per. So I will try to change WebRTC folder in a Chromium enlistment,
> and to ensure this change actually helps before submitting.

I have tried on my machine. It looks good. I will go ahead to submit this change
first, and make another one in WebRTC to use HISTOGRAM in
BlankDetectorDesktopCapturerWrapper.

[Hzj_jie, 2017-03-07 03:10:59]

The CQ bit was checked by zijiehe@chromium.org

[commit-bot: I haz the power, 2017-03-07 03:11:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 03:21:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 03:21:31]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Hzj_jie, 2017-03-07 20:35:10]

The CQ bit was checked by zijiehe@chromium.org

[commit-bot: I haz the power, 2017-03-07 20:36:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 20:46:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 20:46:37]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Hzj_jie, 2017-03-07 22:06:05]

zijiehe@chromium.org changed reviewers:
+ avi@chromium.org, clamy@chromium.org

[Hzj_jie, 2017-03-07 22:08:28]

Hi, Avi and Camille,
I am trying to use HISTOGRAM in webrtc/DesktopCapture. But content/browser,
which is the consumer of the DesktopCapturer component of webrtc does not depend
on init_webrtc.
So this change adds the init_webrtc to the public_deps of content/browser
package to unblock my change.

[Avi (use Gerrit), 2017-03-08 03:27:18]

I suppose? I don't know GN very well.

[Hzj_jie, 2017-03-08 18:34:28]

On 2017/03/08 03:27:18, Avi wrote:
> I suppose? I don't know GN very well.

Sure Avi, I will add another reviewer.

[Hzj_jie, 2017-03-08 18:35:12]

zijiehe@chromium.org changed reviewers:
+ dgozman@chromium.org, kinuko@chromium.org
- avi@chromium.org

[dgozman, 2017-07-15 05:48:08]

dgozman@chromium.org changed reviewers:
- dgozman@chromium.org

[kinuko, 2017-07-24 10:40:39]

Is this one still waiting for review or it's now closed?  (The change itself
looks ok)

[Hzj_jie, 2017-07-24 18:07:57]

On 2017/07/24 10:40:39, kinuko wrote:
> Is this one still waiting for review or it's now closed?  (The change itself
> looks ok)

This is an unurgent change: it impacts only the histogram used in webrtc desktop
capturer component. I am pretty happy if you can lgtm the change to let me
submit it.

[kinuko, 2017-07-25 06:23:48]

ok, lgtm

[Hzj_jie, 2017-07-25 17:08:08]

The CQ bit was checked by zijiehe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-25 17:08:21]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-25 21:21:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-25 21:21:28]

Dry run: This issue passed the CQ dry run.

[Hzj_jie, 2017-07-25 21:27:00]

The CQ bit was checked by zijiehe@chromium.org

[Hzj_jie, 2017-07-25 21:27:00]

The patchset sent to the CQ was uploaded after l-g-t-m from perkj@chromium.org,
kinuko@chromium.org
Link to the patchset: https://codereview.chromium.org/2731803002/#ps40001
(title: "Sync latest changes")

[Hzj_jie, 2017-07-25 21:27:10]

On 2017/07/25 06:23:48, kinuko wrote:
> ok, lgtm

Cheers: I almost forget this change.

[commit-bot: I haz the power, 2017-07-25 21:27:14]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-25 21:32:34]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1501018020310060,
"parent_rev": "7cde380bbded234d30016469065284c8703bb6b3", "commit_rev":
"96d6987c5d68575b222ba9028802d47b889fd658"}

[commit-bot: I haz the power, 2017-07-25 21:32:56]

Description was changed from

==========
content/browser should depend on webrtc_overrides:init_webrtc

BlankDetectorDesktopCapturerWrapper needs to use HISTOGRAM in its
implementation. So content/browser needs to depend on init_webrtc target to get
histogram required components to be built in.
This should fix https://codereview.chromium.org/2709523003/ and
https://codereview.chromium.org/2725143004/.

BUG=682112
==========

to

==========
content/browser should depend on webrtc_overrides:init_webrtc

BlankDetectorDesktopCapturerWrapper needs to use HISTOGRAM in its
implementation. So content/browser needs to depend on init_webrtc target to get
histogram required components to be built in.
This should fix https://codereview.chromium.org/2709523003/ and
https://codereview.chromium.org/2725143004/.

BUG=682112

Review-Url: https://codereview.chromium.org/2731803002
Cr-Commit-Position: refs/heads/master@{#489442}
Committed:
https://chromium.googlesource.com/chromium/src/+/96d6987c5d68575b222ba9028802...
==========

[commit-bot: I haz the power, 2017-07-25 21:32:57]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/96d6987c5d68575b222ba9028802...