Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Issue 2731723002: [Turbofan] Don't inline if we never saw a function. (Closed)

Created:
3 years, 9 months ago by mvstanton
Modified:
3 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Turbofan] Don't inline if we never saw a function. Also prevent division by zero. R=tebbi@chromium.org BUG= Review-Url: https://codereview.chromium.org/2731723002 Cr-Commit-Position: refs/heads/master@{#43590} Committed: https://chromium.googlesource.com/v8/v8/+/5f10c6820d9bbe50389b20cfc2bc2fe127e5b1b1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M src/compiler/js-inlining-heuristic.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/feedback-vector.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
mvstanton
Hi Tobias, PTAL, thx!
3 years, 9 months ago (2017-03-03 14:28:00 UTC) #1
Tobias Tebbi
On 2017/03/03 14:28:00, mvstanton wrote: > Hi Tobias, PTAL, thx! lgtm
3 years, 9 months ago (2017-03-03 14:29:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2731723002/1
3 years, 9 months ago (2017-03-03 14:30:04 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/35951)
3 years, 9 months ago (2017-03-03 14:32:49 UTC) #8
Michael Starzinger
LGTM.
3 years, 9 months ago (2017-03-03 14:49:28 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2731723002/1
3 years, 9 months ago (2017-03-03 14:52:53 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-03-03 14:54:40 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/5f10c6820d9bbe50389b20cfc2bc2fe127e...

Powered by Google App Engine
This is Rietveld 408576698