[WebAgentsAPI]: Introduce OverloadSetAdapter.

[WebAgentsAPI]: Introduce OverloadSetAdapter.

Currently, effective_overload_set takes a list of Jinja2 method
contexts. This is fairly easy to replicate in Web Agent API
generator, but I would prefer to rely on idl_definition types
(that is, taking a list of IdlOperations as arguments).

I tried a couple of ways to refactor effective_overload_set to
use them directly, but all of them were rather expensive, so
I settled on a simple adapter pattern.

BUG=683743
R=bashi,yukishiino,haraken

Review-Url: https://codereview.chromium.org/2731683002
Cr-Commit-Position: refs/heads/master@{#454584}
Committed: https://chromium.googlesource.com/chromium/src/+/6d2b4f8955d1733666dfc7a0d0309b65566fa20d

[dglazkov, 2017-03-03 03:51:52]

The CQ bit was checked by dglazkov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-03 03:52:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bashi, 2017-03-03 04:39:04]

lgtm

[commit-bot: I haz the power, 2017-03-03 05:09:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-03 05:09:38]

Dry run: This issue passed the CQ dry run.

[dglazkov, 2017-03-03 15:03:18]

The CQ bit was checked by dglazkov@chromium.org

[commit-bot: I haz the power, 2017-03-03 15:03:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-03 15:09:45]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1488553398907080, "parent_rev":
"d75e16c38dd0918d0f38307aacd51241ee56f318", "commit_rev":
"6d2b4f8955d1733666dfc7a0d0309b65566fa20d"}

[commit-bot: I haz the power, 2017-03-03 15:10:23]

Description was changed from

==========
[WebAgentsAPI]: Introduce OverloadSetAdapter.

Currently, effective_overload_set takes a list of Jinja2 method
contexts. This is fairly easy to replicate in Web Agent API
generator, but I would prefer to rely on idl_definition types
(that is, taking a list of IdlOperations as arguments).

I tried a couple of ways to refactor effective_overload_set to
use them directly, but all of them were rather expensive, so
I settled on a simple adapter pattern.

BUG=683743
R=bashi,yukishiino,haraken
==========

to

==========
[WebAgentsAPI]: Introduce OverloadSetAdapter.

Currently, effective_overload_set takes a list of Jinja2 method
contexts. This is fairly easy to replicate in Web Agent API
generator, but I would prefer to rely on idl_definition types
(that is, taking a list of IdlOperations as arguments).

I tried a couple of ways to refactor effective_overload_set to
use them directly, but all of them were rather expensive, so
I settled on a simple adapter pattern.

BUG=683743
R=bashi,yukishiino,haraken

Review-Url: https://codereview.chromium.org/2731683002
Cr-Commit-Position: refs/heads/master@{#454584}
Committed:
https://chromium.googlesource.com/chromium/src/+/6d2b4f8955d1733666dfc7a0d030...
==========

[commit-bot: I haz the power, 2017-03-03 15:10:24]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6d2b4f8955d1733666dfc7a0d030...

[haraken, 2017-03-03 18:52:45]

> Currently, effective_overload_set takes a list of Jinja2 method
> contexts. This is fairly easy to replicate in Web Agent API
> generator, but I would prefer to rely on idl_definition types
> (that is, taking a list of IdlOperations as arguments).

Hmm, what is our long-term plan here? Are we planning to support both
idl_definition types and Jinja2's context? It might be a bit unfortunate if we
need to add the adaptor pattern here and there.

[dglazkov, 2017-03-04 00:43:03]

On 2017/03/03 at 18:52:45, haraken wrote:
> > Currently, effective_overload_set takes a list of Jinja2 method
> > contexts. This is fairly easy to replicate in Web Agent API
> > generator, but I would prefer to rely on idl_definition types
> > (that is, taking a list of IdlOperations as arguments).
> 
> Hmm, what is our long-term plan here? Are we planning to support both
idl_definition types and Jinja2's context? It might be a bit unfortunate if we
need to add the adaptor pattern here and there.

That's a good question. I tried to document my thinking in
https://bugs.chromium.org/p/chromium/issues/detail?id=698440