Remove WmWindowProperty

Remove WmWindowProperty

Since ui::Window is removed and we solely use aura::Window, we can 
remove usage of WmWindowPerperty safely and start to use aura window  
property instead. 

Since this is a refactor, no new test added.

BUG=687649
Review-Url: https://codereview.chromium.org/2731663002
Cr-Commit-Position: refs/heads/master@{#454671}
Committed: https://chromium.googlesource.com/chromium/src/+/a12aab1f97b16006dbbe8bad1969377040c6da1a

[yiyix, 2017-03-03 02:42:58]

Description was changed from

==========
remove WmWindow

BUG=687649
==========

to

==========
Remove WmWindowProperty

Since ui::Window is removed and we solely use aura::Window, we can 
remove usage of WmWindowPerperty safely and start to use aura window  
property instead. 

BUG=687649
==========

[yiyix, 2017-03-03 03:14:31]

Patchset #1 (id:1) has been deleted

[yiyix, 2017-03-03 03:14:58]

Description was changed from

==========
Remove WmWindowProperty

Since ui::Window is removed and we solely use aura::Window, we can 
remove usage of WmWindowPerperty safely and start to use aura window  
property instead. 

BUG=687649
==========

to

==========
Remove WmWindowProperty

Since ui::Window is removed and we solely use aura::Window, we can 
remove usage of WmWindowPerperty safely and start to use aura window  
property instead. 

Since this is a refactor, no new test added.

BUG=687649
==========

[yiyix, 2017-03-03 03:15:51]

yiyix@chromium.org changed reviewers:
+ sky@chromium.org

[sky, 2017-03-03 15:41:42]

Nice cleanup! One minor comment.

https://codereview.chromium.org/2731663002/diff/20001/chrome/browser/ui/ash/l...
File chrome/browser/ui/ash/launcher/multi_profile_browser_status_monitor.cc
(right):

https://codereview.chromium.org/2731663002/diff/20001/chrome/browser/ui/ash/l...
chrome/browser/ui/ash/launcher/multi_profile_browser_status_monitor.cc:81:
aura_window->SetProperty<int>(
If you need a cast it should match how the property is defined, and I would put
it around the value, e.g.:

aura_window->SetProperty(..., static_cast<int32_t>(...));

[yiyix, 2017-03-03 16:25:12]

@sky, could you please take another look? Thank you.

https://codereview.chromium.org/2731663002/diff/20001/chrome/browser/ui/ash/l...
File chrome/browser/ui/ash/launcher/multi_profile_browser_status_monitor.cc
(right):

https://codereview.chromium.org/2731663002/diff/20001/chrome/browser/ui/ash/l...
chrome/browser/ui/ash/launcher/multi_profile_browser_status_monitor.cc:81:
aura_window->SetProperty<int>(
On 2017/03/03 15:41:42, sky wrote:
> If you need a cast it should match how the property is defined, and I would
put
> it around the value, e.g.:
> 
> aura_window->SetProperty(..., static_cast<int32_t>(...));

true, easier to understand. Thanks.
Done

[yiyix, 2017-03-03 16:25:17]

The CQ bit was checked by yiyix@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-03 16:25:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-03 16:48:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-03 16:48:59]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sky, 2017-03-03 17:05:53]

LGTM

[yiyix, 2017-03-03 18:57:15]

The CQ bit was checked by yiyix@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-03 18:57:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yiyix, 2017-03-03 19:12:08]

Patchset #3 (id:60001) has been deleted

[yiyix, 2017-03-03 19:12:28]

The CQ bit was checked by yiyix@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-03 19:12:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-03 19:32:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-03 19:32:34]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yiyix, 2017-03-03 19:39:38]

The CQ bit was checked by yiyix@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-03 19:40:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yiyix, 2017-03-03 19:53:06]

Patchset #3 (id:80001) has been deleted

[commit-bot: I haz the power, 2017-03-03 20:52:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-03 20:52:25]

Dry run: This issue passed the CQ dry run.

[yiyix, 2017-03-03 20:52:55]

The CQ bit was checked by yiyix@chromium.org

[yiyix, 2017-03-03 20:52:56]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2731663002/#ps100001
(title: "rebase")

[commit-bot: I haz the power, 2017-03-03 20:53:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-03 21:04:38]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1488574375691890,
"parent_rev": "795a3d80dd8d970440ac4f2b575b4dbab8db829e", "commit_rev":
"a12aab1f97b16006dbbe8bad1969377040c6da1a"}

[commit-bot: I haz the power, 2017-03-03 21:06:05]

Description was changed from

==========
Remove WmWindowProperty

Since ui::Window is removed and we solely use aura::Window, we can 
remove usage of WmWindowPerperty safely and start to use aura window  
property instead. 

Since this is a refactor, no new test added.

BUG=687649
==========

to

==========
Remove WmWindowProperty

Since ui::Window is removed and we solely use aura::Window, we can 
remove usage of WmWindowPerperty safely and start to use aura window  
property instead. 

Since this is a refactor, no new test added.

BUG=687649

Review-Url: https://codereview.chromium.org/2731663002
Cr-Commit-Position: refs/heads/master@{#454671}
Committed:
https://chromium.googlesource.com/chromium/src/+/a12aab1f97b16006dbbe8bad1969...
==========

[commit-bot: I haz the power, 2017-03-03 21:06:06]

Committed patchset #3 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/a12aab1f97b16006dbbe8bad1969...