Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(623)

Unified Diff: net/cert/x509_certificate_ios.cc

Issue 2731603002: Check TBSCertificate.algorithm and Certificate.signatureAlgorithm for (Closed)
Patch Set: fix Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/cert/x509_certificate_ios.cc
diff --git a/net/cert/x509_certificate_ios.cc b/net/cert/x509_certificate_ios.cc
index 18ce828df728c2f8447ebbbb91c5e22222da5a68..737970768fbbeb59c9ec546c500ad3c7766b031c 100644
--- a/net/cert/x509_certificate_ios.cc
+++ b/net/cert/x509_certificate_ios.cc
@@ -358,29 +358,6 @@ void X509Certificate::GetPublicKeyInfo(OSCertHandle os_cert,
*size_bits = EVP_PKEY_bits(key);
}
-// static
-X509Certificate::SignatureHashAlgorithm
-X509Certificate::GetSignatureHashAlgorithm(OSCertHandle cert_handle) {
- bssl::UniquePtr<X509> cert = OSCertHandleToOpenSSL(cert_handle);
- if (!cert)
- return kSignatureHashAlgorithmOther;
-
- // TODO(eroman): This duplicates code with x509_certificate_openssl.cc
- int sig_alg = OBJ_obj2nid(cert->sig_alg->algorithm);
- if (sig_alg == NID_md2WithRSAEncryption)
- return kSignatureHashAlgorithmMd2;
- if (sig_alg == NID_md4WithRSAEncryption)
- return kSignatureHashAlgorithmMd4;
- if (sig_alg == NID_md5WithRSAEncryption || sig_alg == NID_md5WithRSA)
- return kSignatureHashAlgorithmMd5;
- if (sig_alg == NID_sha1WithRSAEncryption || sig_alg == NID_dsaWithSHA ||
- sig_alg == NID_dsaWithSHA1 || sig_alg == NID_dsaWithSHA1_2 ||
- sig_alg == NID_sha1WithRSA || sig_alg == NID_ecdsa_with_SHA1) {
- return kSignatureHashAlgorithmSha1;
- }
- return kSignatureHashAlgorithmOther;
-}
-
bool X509Certificate::SupportsSSLClientAuth() const {
return false;
}

Powered by Google App Engine
This is Rietveld 408576698