Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Unified Diff: net/cert/x509_certificate.h

Issue 2731603002: Check TBSCertificate.algorithm and Certificate.signatureAlgorithm for (Closed)
Patch Set: fix Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/cert/x509_certificate.h
diff --git a/net/cert/x509_certificate.h b/net/cert/x509_certificate.h
index 0aff1be610067f0eb75fbe6b430fbb66cc665476..cab0889761ba16e157c92789eda85834c1e0f6b0 100644
--- a/net/cert/x509_certificate.h
+++ b/net/cert/x509_certificate.h
@@ -80,14 +80,6 @@ class NET_EXPORT X509Certificate
kPublicKeyTypeECDH
};
- enum SignatureHashAlgorithm {
- kSignatureHashAlgorithmMd2,
- kSignatureHashAlgorithmMd4,
- kSignatureHashAlgorithmMd5,
- kSignatureHashAlgorithmSha1,
- kSignatureHashAlgorithmOther,
- };
-
enum Format {
// The data contains a single DER-encoded certificate, or a PEM-encoded
// DER certificate with the PEM encoding block name of "CERTIFICATE".
@@ -323,15 +315,6 @@ class NET_EXPORT X509Certificate
size_t* size_bits,
PublicKeyType* type);
- // Returns the digest algorithm used in |cert_handle|'s signature.
- // If the digest algorithm cannot be determined, or if it is not one
- // of the explicitly enumerated values, kSignatureHashAlgorithmOther
- // will be returned.
- // NOTE: No validation of the signature is performed, and thus invalid
- // signatures may result in seemingly meaningful values.
- static SignatureHashAlgorithm GetSignatureHashAlgorithm(
- OSCertHandle cert_handle);
-
// Returns the OSCertHandle of this object. Because of caching, this may
// differ from the OSCertHandle originally supplied during initialization.
// Note: On Windows, CryptoAPI may return unexpected results if this handle

Powered by Google App Engine
This is Rietveld 408576698