Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1123)

Unified Diff: pkg/front_end/lib/src/fasta/kernel/kernel_procedure_builder.dart

Issue 2731553004: [Fasta] Offset and end offset on procedures (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/kernel/kernel_procedure_builder.dart
diff --git a/pkg/front_end/lib/src/fasta/kernel/kernel_procedure_builder.dart b/pkg/front_end/lib/src/fasta/kernel/kernel_procedure_builder.dart
index 08b6f474be30a04299abd0923350f7ee849913dc..87294bfe8c12d2deee84e98c6cb8a3ce87b906f9 100644
--- a/pkg/front_end/lib/src/fasta/kernel/kernel_procedure_builder.dart
+++ b/pkg/front_end/lib/src/fasta/kernel/kernel_procedure_builder.dart
@@ -191,10 +191,13 @@ class KernelProcedureBuilder extends KernelFunctionBuilder {
ProcedureKind kind,
KernelLibraryBuilder compilationUnit,
int charOffset,
+ int charEndOffset,
[String nativeMethodName,
this.redirectionTarget])
: procedure = new Procedure(null, kind, null,
- fileUri: compilationUnit?.relativeFileUri),
+ fileUri: compilationUnit?.relativeFileUri)
+ ..fileOffset = charOffset
+ ..fileEndOffset = charEndOffset,
super(metadata, modifiers, returnType, name, typeVariables, formals,
compilationUnit, charOffset, nativeMethodName);
@@ -256,9 +259,13 @@ class KernelConstructorBuilder extends KernelFunctionBuilder {
List<FormalParameterBuilder> formals,
KernelLibraryBuilder compilationUnit,
int charOffset,
+ int charEndOffset,
[String nativeMethodName])
: super(metadata, modifiers, returnType, name, typeVariables, formals,
- compilationUnit, charOffset, nativeMethodName);
+ compilationUnit, charOffset, nativeMethodName) {
ahe 2017/03/03 11:19:06 Would you mind changing this to: constructor = ne
+ constructor.fileOffset = charOffset;
+ constructor.fileEndOffset = charEndOffset;
+ }
bool get isInstanceMember => false;
« no previous file with comments | « pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart ('k') | pkg/front_end/lib/src/fasta/kernel/kernel_target.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698