[Fasta] Offset and end offset on procedures

pkg/front_end/lib/src/fasta/kernel/kernel_procedure_builder.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library fasta.kernel_procedure_builder;
 
 import 'package:kernel/ast.dart'
     show
         Arguments,
         AsyncMarker,
@@ skipping 173 matching lines @@
       List<MetadataBuilder> metadata,
       int modifiers,
       KernelTypeBuilder returnType,
       String name,
       List<TypeVariableBuilder> typeVariables,
       List<FormalParameterBuilder> formals,
       this.actualAsyncModifier,
       ProcedureKind kind,
       KernelLibraryBuilder compilationUnit,
       int charOffset,
+      int charEndOffset,
       [String nativeMethodName,
       this.redirectionTarget])
       : procedure = new Procedure(null, kind, null,
-            fileUri: compilationUnit?.relativeFileUri),
+            fileUri: compilationUnit?.relativeFileUri)
+          ..fileOffset = charOffset
+          ..fileEndOffset = charEndOffset,
         super(metadata, modifiers, returnType, name, typeVariables, formals,
             compilationUnit, charOffset, nativeMethodName);
 
   ProcedureKind get kind => procedure.kind;
 
   AsyncMarker get asyncModifier => actualAsyncModifier;
 
   Statement get body {
     if (actualBody == null &&
         redirectionTarget == null &&
@@ skipping 41 matching lines @@
 
   KernelConstructorBuilder(
       List<MetadataBuilder> metadata,
       int modifiers,
       KernelTypeBuilder returnType,
       String name,
       List<TypeVariableBuilder> typeVariables,
       List<FormalParameterBuilder> formals,
       KernelLibraryBuilder compilationUnit,
       int charOffset,
+      int charEndOffset,
       [String nativeMethodName])
       : super(metadata, modifiers, returnType, name, typeVariables, formals,
-            compilationUnit, charOffset, nativeMethodName);
+            compilationUnit, charOffset, nativeMethodName) {

[ahe, 2017/03/03 11:19:06]

Would you mind changing this to:

constructor = new Constructor(null)
  ..fileOffset = charOffset
  ..fileEndOffset = charEndOffset;

+    constructor.fileOffset = charOffset;
+    constructor.fileEndOffset = charEndOffset;
+  }
 
   bool get isInstanceMember => false;
 
   bool get isConstructor => true;
 
   AsyncMarker get asyncModifier => AsyncMarker.Sync;
 
   ProcedureKind get kind => null;
 
   Constructor build(Library library) {
@@ skipping 69 matching lines @@
         }
       }
       initializers.add(initializer..parent = constructor);
       initializers.add(superInitializer);
       return;
     }
     initializers.add(initializer);
     initializer.parent = constructor;
   }
 }