Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 2731553004: [Fasta] Offset and end offset on procedures (Closed)

Created:
3 years, 9 months ago by jensj
Modified:
3 years, 9 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -15 lines) Patch
M pkg/front_end/lib/src/fasta/kernel/kernel_enum_builder.dart View 3 chunks +11 lines, -4 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart View 6 chunks +8 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_procedure_builder.dart View 1 3 chunks +10 lines, -3 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_target.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/outline_builder.dart View 4 chunks +25 lines, -5 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/source_library_builder.dart View 2 chunks +3 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 5 (2 generated)
jensj
With this and the included source code (i.e. dependent patch set and compile with --include-source) ...
3 years, 9 months ago (2017-03-03 10:26:50 UTC) #2
ahe
lgtm Great news on debugging! https://codereview.chromium.org/2731553004/diff/1/pkg/front_end/lib/src/fasta/kernel/kernel_procedure_builder.dart File pkg/front_end/lib/src/fasta/kernel/kernel_procedure_builder.dart (right): https://codereview.chromium.org/2731553004/diff/1/pkg/front_end/lib/src/fasta/kernel/kernel_procedure_builder.dart#newcode265 pkg/front_end/lib/src/fasta/kernel/kernel_procedure_builder.dart:265: compilationUnit, charOffset, nativeMethodName) { ...
3 years, 9 months ago (2017-03-03 11:19:07 UTC) #3
jensj
3 years, 9 months ago (2017-03-08 08:23:49 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
15dc449ceaccddb56aeafe5eb2e44a8e91f80869 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698