Fix invalid cast to BrowsingDataRemoverImpl

Fix invalid cast to BrowsingDataRemoverImpl

BUG=697935
Review-Url: https://codereview.chromium.org/2731523004
Cr-Commit-Position: refs/heads/master@{#454560}
Committed: https://chromium.googlesource.com/chromium/src/+/dfd53b092ed0d99a03528cfcfe65a01b625e7c2e

[dullweber, 2017-03-03 08:34:34]

dullweber@chromium.org changed reviewers:
+ msramek@chromium.org

[dullweber, 2017-03-03 08:34:34]

Seems like I broke a build. I don't see a reason, why the cast to
BrowsingDataRemoverImpl* is neccessary so I changed it to BrowsingDataRemover*

[dullweber, 2017-03-03 09:32:56]

On 2017/03/03 08:34:34, dullweber wrote:
> Seems like I broke a build. I don't see a reason, why the cast to
> BrowsingDataRemoverImpl* is neccessary so I changed it to BrowsingDataRemover*

Oh, the cast to *Impl was neccessary because only the impl is a KeyedService. I
moved the inheritance to the base class.

[dullweber, 2017-03-03 09:33:03]

The CQ bit was checked by dullweber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-03 09:33:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dullweber, 2017-03-03 10:07:32]

dullweber@chromium.org changed reviewers:
+ bauerb@chromium.org

[dullweber, 2017-03-03 10:07:33]

bauerb@chromium.org:  Martin is ooo today, could you take a look at this cl? We
changed the inheritance structure of BrowsingDataRemover in
http://crrev.com/2720723002. That broke a build (http://crbug.com/697935).

[commit-bot: I haz the power, 2017-03-03 10:12:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-03 10:12:41]

Dry run: This issue passed the CQ dry run.

[Bernhard Bauer, 2017-03-03 10:48:12]

lgtm

[dullweber, 2017-03-03 10:51:07]

The CQ bit was checked by dullweber@chromium.org

[commit-bot: I haz the power, 2017-03-03 10:51:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-03 10:54:53]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488538267233160,
"parent_rev": "ebcd266f8e04c1ebebf3e0eca08f6683641cf613", "commit_rev":
"dfd53b092ed0d99a03528cfcfe65a01b625e7c2e"}

[commit-bot: I haz the power, 2017-03-03 10:55:30]

Description was changed from

==========
Fix invalid cast to BrowsingDataRemoverImpl

BUG=697935
==========

to

==========
Fix invalid cast to BrowsingDataRemoverImpl

BUG=697935

Review-Url: https://codereview.chromium.org/2731523004
Cr-Commit-Position: refs/heads/master@{#454560}
Committed:
https://chromium.googlesource.com/chromium/src/+/dfd53b092ed0d99a03528cfcfe65...
==========

[commit-bot: I haz the power, 2017-03-03 10:55:31]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/dfd53b092ed0d99a03528cfcfe65...

[msramek, 2017-03-06 09:26:35]

Post-facto LGTM, thanks a lot for fixing this!

The downcast to *Impl and the override to Mock* have both been there before your
CL, so it's not you who broke this. I'm not sure why the bots only noticed now
:-/