Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Issue 2731413003: Remove UWS Rappor (Closed)

Created:
3 years, 9 months ago by Steven Holte
Modified:
3 years, 9 months ago
CC:
chromium-reviews, grt+watch_chromium.org, ftirelo+watch_chromium.org, joenotcharles+watch_chromium.org, alito+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove UWS Rappor TBR=laforge BUG=696797 Review-Url: https://codereview.chromium.org/2731413003 Cr-Commit-Position: refs/heads/master@{#455300} Committed: https://chromium.googlesource.com/chromium/src/+/35cb1d3e7a0b1ebe62b485ff06bf641a01d8c36a

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove BEHAVIOUR_LOG_TO_RAPPOR #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -18 lines) Patch
M chrome/browser/component_updater/sw_reporter_installer_win.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/component_updater/sw_reporter_installer_win_unittest.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/safe_browsing/srt_fetcher_browsertest_win.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/srt_fetcher_win.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/srt_fetcher_win.cc View 4 chunks +2 lines, -13 lines 0 comments Download

Messages

Total messages: 23 (15 generated)
Steven Holte
3 years, 9 months ago (2017-03-07 19:48:35 UTC) #3
csharp
lgtm
3 years, 9 months ago (2017-03-07 21:55:20 UTC) #4
joenotcharles
https://codereview.chromium.org/2731413003/diff/1/chrome/browser/safe_browsing/srt_fetcher_win.cc File chrome/browser/safe_browsing/srt_fetcher_win.cc (left): https://codereview.chromium.org/2731413003/diff/1/chrome/browser/safe_browsing/srt_fetcher_win.cc#oldcode827 chrome/browser/safe_browsing/srt_fetcher_win.cc:827: SwReporterInvocation::BEHAVIOUR_LOG_TO_RAPPOR)); Can you remove BEHAVIOUR_LOG_TO_RAPPOR entirely please?
3 years, 9 months ago (2017-03-07 22:11:41 UTC) #6
Steven Holte
+nparker https://codereview.chromium.org/2731413003/diff/1/chrome/browser/safe_browsing/srt_fetcher_win.cc File chrome/browser/safe_browsing/srt_fetcher_win.cc (left): https://codereview.chromium.org/2731413003/diff/1/chrome/browser/safe_browsing/srt_fetcher_win.cc#oldcode827 chrome/browser/safe_browsing/srt_fetcher_win.cc:827: SwReporterInvocation::BEHAVIOUR_LOG_TO_RAPPOR)); On 2017/03/07 22:11:41, joenotcharles wrote: > Can ...
3 years, 9 months ago (2017-03-07 22:34:10 UTC) #8
Joe Mason
lgtm
3 years, 9 months ago (2017-03-07 22:37:37 UTC) #10
Nathan Parker
safe_browsing/* LGTM
3 years, 9 months ago (2017-03-07 23:08:35 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2731413003/20001
3 years, 9 months ago (2017-03-07 23:51:08 UTC) #20
commit-bot: I haz the power
3 years, 9 months ago (2017-03-07 23:59:35 UTC) #23
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/35cb1d3e7a0b1ebe62b485ff06bf...

Powered by Google App Engine
This is Rietveld 408576698