MD Settings: Privacy: Show dialog when changing do-not-track

chrome/browser/resources/settings/privacy_page/privacy_page.html

Index: chrome/browser/resources/settings/privacy_page/privacy_page.html
diff --git a/chrome/browser/resources/settings/privacy_page/privacy_page.html b/chrome/browser/resources/settings/privacy_page/privacy_page.html
index 3e2e0de7d61dfd29822b855f83f6444b4bcca30f..690c6b546e9ad81442de13f422ab59fb2b55048c 100644
--- a/chrome/browser/resources/settings/privacy_page/privacy_page.html
+++ b/chrome/browser/resources/settings/privacy_page/privacy_page.html
@@ -1,4 +1,5 @@
 <link rel="import" href="chrome://resources/html/polymer.html">
+<link rel="import" href="chrome://resources/cr_elements/cr_dialog/cr_dialog.html">
 <link rel="import" href="chrome://resources/cr_elements/policy/cr_policy_vars_css.html">
 <link rel="import" href="chrome://resources/html/i18n_behavior.html">
 <link rel="import" href="chrome://resources/html/web_ui_listener_behavior.html">
@@ -109,9 +110,27 @@
 </if><!-- not chromeos -->
 </if><!-- _google_chrome -->
         <div class="settings-box">
-          <settings-toggle-button class="start"
-              pref="{{prefs.enable_do_not_track}}"
-              label="$i18n{doNotTrack}">
+          <template id="doNotTrackDialogIf" is="dom-if"
+              if="[[showDoNotTrackDialog_]]">
+            <dialog is="cr-dialog" id="confirmDoNotTrackDialog"
+                close-text="$i18n{close}" on-cancel="onDoNotTrackDialogCancel_">
+              <div class="title">$i18n{doNotTrackDialogTitle}</div>
+              <div class="body">$i18nRaw{doNotTrackDialogMessage}</div>
+              <div class="button-container">
+                <paper-button class="cancel-button"
+                    on-tap="onDoNotTrackDialogCancel_">
+                  $i18n{cancel}
+                </paper-button>
+                <paper-button class="action-button"
+                    on-tap="onDoNotTrackDialogConfirm_">
+                  $i18n{confirm}
+                </paper-button>
+              </div>
+            </dialog>
+          </template>

[Dan Beam, 2017/03/10 23:30:50]

nit: this is BEFORE the control, we talked this morning about AFTER the control

[stevenjb, 2017/03/10 23:58:20]

I guess I was confused in the discussion, I thought I mentioned that I put the
dialog before the control because I felt that was more intuitive (tab returns to
the same control), sorry if I misunderstood, you think after the control is
better?

[Dan Beam, 2017/03/13 21:57:51]

let's just do whatever until somebody sweeps the whole UI consistently

[stevenjb, 2017/03/13 23:29:02]

Acknowledged.

+          <settings-toggle-button id="doNotTrack" class="start"
+              pref="{{prefs.enable_do_not_track}}" label="$i18n{doNotTrack}"
+              on-change="onDoNotTrackChange_" no-set-pref>
           </settings-toggle-button>
         </div>
 <if expr="chromeos">