MD Settings: Privacy: Show dialog when changing do-not-track

chrome/browser/resources/settings/privacy_page/privacy_page.html

 <link rel="import" href="chrome://resources/html/polymer.html">
+<link rel="import" href="chrome://resources/cr_elements/cr_dialog/cr_dialog.html">
 <link rel="import" href="chrome://resources/cr_elements/policy/cr_policy_vars_css.html">
 <link rel="import" href="chrome://resources/html/i18n_behavior.html">
 <link rel="import" href="chrome://resources/html/web_ui_listener_behavior.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/iron-flex-layout-classes.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/neon-animation/neon-animatable.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-button.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper-icon-button-light.html">
 <link rel="import" href="../clear_browsing_data_dialog/clear_browsing_data_dialog.html">
 <link rel="import" href="../controls/settings_toggle_button.html">
 <link rel="import" href="../lifetime_browser_proxy.html">
@@ skipping 90 matching lines @@
               <paper-button on-tap="onRestartTap_" id="restart"
                   class="more-actions">
                 $i18n{restart}
               </paper-button>
             </template>
           </settings-toggle-button>
         </div>
 </if><!-- not chromeos -->
 </if><!-- _google_chrome -->
         <div class="settings-box">
-          <settings-toggle-button class="start"
-              pref="{{prefs.enable_do_not_track}}"
-              label="$i18n{doNotTrack}">
+          <template id="doNotTrackDialogIf" is="dom-if"
+              if="[[showDoNotTrackDialog_]]">
+            <dialog is="cr-dialog" id="confirmDoNotTrackDialog"
+                close-text="$i18n{close}" on-cancel="onDoNotTrackDialogCancel_">
+              <div class="title">$i18n{doNotTrackDialogTitle}</div>
+              <div class="body">$i18nRaw{doNotTrackDialogMessage}</div>
+              <div class="button-container">
+                <paper-button class="cancel-button"
+                    on-tap="onDoNotTrackDialogCancel_">
+                  $i18n{cancel}
+                </paper-button>
+                <paper-button class="action-button"
+                    on-tap="onDoNotTrackDialogConfirm_">
+                  $i18n{confirm}
+                </paper-button>
+              </div>
+            </dialog>
+          </template>

[Dan Beam, 2017/03/10 23:30:50]

nit: this is BEFORE the control, we talked this morning about AFTER the control

[stevenjb, 2017/03/10 23:58:20]

I guess I was confused in the discussion, I thought I mentioned that I put the
dialog before the control because I felt that was more intuitive (tab returns to
the same control), sorry if I misunderstood, you think after the control is
better?

[Dan Beam, 2017/03/13 21:57:51]

let's just do whatever until somebody sweeps the whole UI consistently

[stevenjb, 2017/03/13 23:29:02]

Acknowledged.

+          <settings-toggle-button id="doNotTrack" class="start"
+              pref="{{prefs.enable_do_not_track}}" label="$i18n{doNotTrack}"
+              on-change="onDoNotTrackChange_" no-set-pref>
           </settings-toggle-button>
         </div>
 <if expr="chromeos">
         <div class="settings-box">
           <settings-toggle-button class="start"
               pref="{{prefs.cros.device.attestation_for_content_protection_enabled}}"
               label="$i18n{enableContentProtectionAttestation}">
           </settings-toggle-button>
         </div>
         <div class="settings-box">
@@ skipping 328 matching lines @@
                 category="{{ContentSettingsTypes.PROTECTED_CONTENT}}">
             </category-setting-exceptions>
           </template>
 </if>
         </settings-subpage>
       </template>
     </settings-animated-pages>
   </template>
   <script src="privacy_page.js"></script>
 </dom-module>