Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 2731393003: Set allow_user_segv_handler asan option (Closed)

Created:
3 years, 9 months ago by Eric Holk
Modified:
3 years, 9 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set allow_user_segv_handler asan option V8's signal handler based bounds checking solution needs to be able to install a custom signal handler. Unfortunately, asan does not allow this by default. BUG=v8:5277 Review-Url: https://codereview.chromium.org/2731393003 Cr-Commit-Position: refs/heads/master@{#455218} Committed: https://chromium.googlesource.com/chromium/src/+/8e6e95fce9bb5e972c0c96bff0d0a8ea5d7f068a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M build/sanitizers/sanitizer_options.cc View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Eric Holk
Here's the rietveld version of https://chromium-review.googlesource.com/c/450986/
3 years, 9 months ago (2017-03-07 19:25:10 UTC) #2
scottmg
rs lgtm based on review in https://codereview.chromium.org/2726303004/
3 years, 9 months ago (2017-03-07 19:53:13 UTC) #3
Eric Holk
On 2017/03/07 19:53:13, scottmg wrote: > rs lgtm based on review in https://codereview.chromium.org/2726303004/ Thanks!
3 years, 9 months ago (2017-03-07 19:56:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2731393003/1
3 years, 9 months ago (2017-03-07 19:57:18 UTC) #6
commit-bot: I haz the power
3 years, 9 months ago (2017-03-07 21:06:41 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8e6e95fce9bb5e972c0c96bff0d0...

Powered by Google App Engine
This is Rietveld 408576698