Remove SK_SUPPORT_LEGACY_BROKEN_LERP

Remove SK_SUPPORT_LEGACY_BROKEN_LERP

Turn on improved Skia LERP functions.  This is expected to trivially affect lots of
pixel tests (minor anti-aliasing diffs).


BUG=696216
TBR=mtklein@google.com,liyuquian@google.com
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2731393002 .
Cr-Commit-Position: refs/heads/master@{#456303}
Committed: https://chromium.googlesource.com/chromium/src/+/393cf62456bcd37c4dd4dd2c995597c5d5012ea6

[f(malita), 2017-03-06 21:48:39]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-06 21:49:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-06 22:54:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-06 22:54:10]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[f(malita), 2017-03-07 14:20:58]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-07 14:21:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 15:48:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 15:48:27]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[f(malita), 2017-03-10 19:43:59]

Description was changed from

==========
Remove SK_SUPPORT_LEGACY_BROKEN_LERP

Test run to gauge the diffs

BUG=696216
==========

to

==========
Remove SK_SUPPORT_LEGACY_BROKEN_LERP

Test run to gauge the diffs

BUG=696216
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[f(malita), 2017-03-10 19:44:02]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-10 19:44:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[f(malita), 2017-03-10 20:02:11]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-10 20:02:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 21:38:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-10 21:39:00]

Dry run: Try jobs failed on following builders:
  linux_trusty_blink_rel on master.tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_trusty_blink_rel/b...)

[f(malita), 2017-03-12 13:57:48]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-12 13:57:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[f(malita), 2017-03-12 14:00:16]

The CQ bit was unchecked by fmalita@chromium.org

[f(malita), 2017-03-12 15:49:27]

Description was changed from

==========
Remove SK_SUPPORT_LEGACY_BROKEN_LERP

Test run to gauge the diffs

BUG=696216
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Remove SK_SUPPORT_LEGACY_BROKEN_LERP

Turn on improved Skia LERP functions.  This is expected to trivially affect lots
of
pixel tests (minor anti-aliasing diffs).


BUG=696216
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[f(malita), 2017-03-12 15:49:27]

fmalita@chromium.org changed reviewers:
+ liyuqian@google.com, mtklein@google.com

[f(malita), 2017-03-12 15:49:55]

Description was changed from

==========
Remove SK_SUPPORT_LEGACY_BROKEN_LERP

Turn on improved Skia LERP functions.  This is expected to trivially affect lots
of
pixel tests (minor anti-aliasing diffs).


BUG=696216
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Remove SK_SUPPORT_LEGACY_BROKEN_LERP

Turn on improved Skia LERP functions.  This is expected to trivially affect lots
of
pixel tests (minor anti-aliasing diffs).


BUG=696216
TBR=mtklein@google.com,liyuquian@google.com
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[f(malita), 2017-03-12 17:07:16]

Note to sheriffs:

This is a massive rebaseline (> 2000 layout test diffs), too big for Rietveld -
so I'm going to land manually.  That means that if we need to revert, the revert
will also have to be manual.

Given the size of the change , there's a significant chance we'll pick up some
flake/incorrect results.  I'll keep an eye on the bots, but if you notice minor
anti-aliasing diffs please don't revert.  Feel free to rebaseline or suppress
and assign to me.  Thanks.

[f(malita), 2017-03-12 17:22:11]

Description was changed from

==========
Remove SK_SUPPORT_LEGACY_BROKEN_LERP

Turn on improved Skia LERP functions.  This is expected to trivially affect lots
of
pixel tests (minor anti-aliasing diffs).


BUG=696216
TBR=mtklein@google.com,liyuquian@google.com
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Remove SK_SUPPORT_LEGACY_BROKEN_LERP

Turn on improved Skia LERP functions.  This is expected to trivially affect lots
of
pixel tests (minor anti-aliasing diffs).


BUG=696216
TBR=mtklein@google.com,liyuquian@google.com
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2731393002 .
Cr-Commit-Position: refs/heads/master@{#456303}
Committed:
https://chromium.googlesource.com/chromium/src/+/393cf62456bcd37c4dd4dd2c9955...
==========

[f(malita), 2017-03-12 17:22:13]

Committed patchset #5 (id:80001) manually as
393cf62456bcd37c4dd4dd2c995597c5d5012ea6 (presubmit successful).

[mtklein_C, 2017-03-13 15:11:36]

mtklein@chromium.org changed reviewers:
+ mtklein@chromium.org

[mtklein_C, 2017-03-13 15:11:37]

lgtm

[liyuqian, 2017-03-13 17:15:40]

On 2017/03/13 15:11:37, mtklein_C wrote:
> lgtm

lgtm