Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 2731383002: [DevTools] Make touch emulation work with OOPIF. (Closed)

Created:
3 years, 9 months ago by dgozman
Modified:
3 years, 9 months ago
Reviewers:
caseq
CC:
chromium-reviews, caseq+blink_chromium.org, jam, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, darin-cc_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Make touch emulation work with OOPIF. We now send touch emulation commands to all targets with TouchEmulation capability. BUG=648126 Review-Url: https://codereview.chromium.org/2731383002 Cr-Commit-Position: refs/heads/master@{#455353} Committed: https://chromium.googlesource.com/chromium/src/+/15e28404267139f257d4767194f780cb448c675d

Patch Set 1 #

Total comments: 2

Patch Set 2 : dialog fix to separate patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M content/browser/devtools/render_frame_devtools_agent_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/emulation/TouchModel.js View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/Target.js View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
dgozman
Could you please take a look?
3 years, 9 months ago (2017-03-06 19:58:43 UTC) #2
caseq
lgtm https://codereview.chromium.org/2731383002/diff/1/third_party/WebKit/Source/devtools/front_end/ui/Dialog.js File third_party/WebKit/Source/devtools/front_end/ui/Dialog.js (left): https://codereview.chromium.org/2731383002/diff/1/third_party/WebKit/Source/devtools/front_end/ui/Dialog.js#oldcode64 third_party/WebKit/Source/devtools/front_end/ui/Dialog.js:64: UI.Dialog._instance.detach(); Wow! How did this work? Should this ...
3 years, 9 months ago (2017-03-07 00:43:07 UTC) #7
dgozman
https://codereview.chromium.org/2731383002/diff/1/third_party/WebKit/Source/devtools/front_end/ui/Dialog.js File third_party/WebKit/Source/devtools/front_end/ui/Dialog.js (left): https://codereview.chromium.org/2731383002/diff/1/third_party/WebKit/Source/devtools/front_end/ui/Dialog.js#oldcode64 third_party/WebKit/Source/devtools/front_end/ui/Dialog.js:64: UI.Dialog._instance.detach(); On 2017/03/07 00:43:07, caseq wrote: > Wow! How ...
3 years, 9 months ago (2017-03-07 21:57:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2731383002/20001
3 years, 9 months ago (2017-03-07 21:58:46 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-08 02:34:13 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/15e28404267139f257d4767194f7...

Powered by Google App Engine
This is Rietveld 408576698