Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 2731363002: [heap] Do not clear mark bits of left trimmed old object start. (Closed)

Created:
3 years, 9 months ago by Hannes Payer (out of office)
Modified:
3 years, 9 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Do not clear mark bits of left trimmed old object start. BUG=chromium:694255 Review-Url: https://codereview.chromium.org/2731363002 Cr-Commit-Position: refs/heads/master@{#43645} Committed: https://chromium.googlesource.com/v8/v8/+/6517b4477cbf13243caf9a5eeb658f8940ad3c44

Patch Set 1 #

Patch Set 2 : [heap] Do not clear mark bits of left trimmed old object start. #

Patch Set 3 : remove return #

Patch Set 4 : still need mark white #

Patch Set 5 : wrong dcheck #

Patch Set 6 : remove optimization #

Patch Set 7 : fix tests #

Patch Set 8 : remove debug code #

Total comments: 2

Patch Set 9 : comment fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -32 lines) Patch
M src/heap/heap.cc View 1 2 3 4 5 1 chunk +0 lines, -10 lines 0 comments Download
M src/heap/incremental-marking.cc View 1 2 3 4 5 6 7 2 chunks +5 lines, -17 lines 0 comments Download
M src/heap/mark-compact-inl.h View 1 2 3 4 5 6 7 8 1 chunk +7 lines, -3 lines 0 comments Download
M src/heap/marking.h View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download
M test/cctest/heap/test-heap.cc View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 31 (27 generated)
ulan
lgtm https://codereview.chromium.org/2731363002/diff/130001/src/heap/mark-compact-inl.h File src/heap/mark-compact-inl.h (right): https://codereview.chromium.org/2731363002/diff/130001/src/heap/mark-compact-inl.h#newcode183 src/heap/mark-compact-inl.h:183: // There are two reasons whwy we can ...
3 years, 9 months ago (2017-03-07 14:48:05 UTC) #24
Hannes Payer (out of office)
https://codereview.chromium.org/2731363002/diff/130001/src/heap/mark-compact-inl.h File src/heap/mark-compact-inl.h (right): https://codereview.chromium.org/2731363002/diff/130001/src/heap/mark-compact-inl.h#newcode183 src/heap/mark-compact-inl.h:183: // There are two reasons whwy we can get ...
3 years, 9 months ago (2017-03-07 14:49:59 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2731363002/150001
3 years, 9 months ago (2017-03-07 14:50:23 UTC) #28
commit-bot: I haz the power
3 years, 9 months ago (2017-03-07 15:16:55 UTC) #31
Message was sent while issue was closed.
Committed patchset #9 (id:150001) as
https://chromium.googlesource.com/v8/v8/+/6517b4477cbf13243caf9a5eeb658f8940a...

Powered by Google App Engine
This is Rietveld 408576698