Record UMA only when network quality is eligible for caching

Record UMA only when network quality is eligible for caching

BUG=699791
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2731333003
Cr-Commit-Position: refs/heads/master@{#455651}
Committed: https://chromium.googlesource.com/chromium/src/+/746ad2a88e424ff48b4153b7db219eea98a0e79d

[tbansal1, 2017-03-07 05:51:36]

Description was changed from

==========
Record UMA only when network quality is eligible for caching

BUG=
==========

to

==========
Record UMA only when network quality is eligible for caching

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

[tbansal1, 2017-03-07 05:52:32]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-07 05:53:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 08:39:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 08:39:25]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[tbansal1, 2017-03-07 18:58:38]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-07 18:59:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 22:17:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 22:17:37]

Dry run: This issue passed the CQ dry run.

[tbansal1, 2017-03-08 23:42:14]

Description was changed from

==========
Record UMA only when network quality is eligible for caching

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

to

==========
Record UMA only when network quality is eligible for caching

BUG=699791
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

[tbansal1, 2017-03-08 23:42:30]

tbansal@chromium.org changed reviewers:
+ ryansturm@chromium.org

[tbansal1, 2017-03-08 23:42:30]

ryansturm: ptal. Thanks.

[RyanSturm, 2017-03-09 00:01:55]

lgtm, feel free to ignore my nit if you disagree

https://codereview.chromium.org/2731333003/diff/1/net/nqe/network_quality_sto...
File net/nqe/network_quality_store.cc (right):

https://codereview.chromium.org/2731333003/diff/1/net/nqe/network_quality_sto...
net/nqe/network_quality_store.cc:104: // If the network name is unavailable,
caching should not be performed. If
This comment seems unnecessary. It describes the code below without providing
any more info. Just remove it.

[tbansal1, 2017-03-09 00:24:00]

https://codereview.chromium.org/2731333003/diff/1/net/nqe/network_quality_sto...
File net/nqe/network_quality_store.cc (right):

https://codereview.chromium.org/2731333003/diff/1/net/nqe/network_quality_sto...
net/nqe/network_quality_store.cc:104: // If the network name is unavailable,
caching should not be performed. If
On 2017/03/09 00:01:55, Ryan Sturm wrote:
> This comment seems unnecessary. It describes the code below without providing
> any more info. Just remove it.

Done.

[tbansal1, 2017-03-09 00:24:05]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-09 00:24:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-09 01:49:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-09 01:49:15]

Dry run: This issue passed the CQ dry run.

[tbansal1, 2017-03-09 02:31:41]

The CQ bit was checked by tbansal@chromium.org

[tbansal1, 2017-03-09 02:31:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
ryansturm@chromium.org
Link to the patchset: https://codereview.chromium.org/2731333003/#ps20001
(title: "rebase, ryansturm comment")

[commit-bot: I haz the power, 2017-03-09 02:32:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-09 03:08:23]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489026701269320,
"parent_rev": "4344f497cf240b361ccc9499ed965aede2f9c49d", "commit_rev":
"746ad2a88e424ff48b4153b7db219eea98a0e79d"}

[commit-bot: I haz the power, 2017-03-09 03:09:08]

Description was changed from

==========
Record UMA only when network quality is eligible for caching

BUG=699791
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

to

==========
Record UMA only when network quality is eligible for caching

BUG=699791
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2731333003
Cr-Commit-Position: refs/heads/master@{#455651}
Committed:
https://chromium.googlesource.com/chromium/src/+/746ad2a88e424ff48b4153b7db21...
==========

[commit-bot: I haz the power, 2017-03-09 03:09:09]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/746ad2a88e424ff48b4153b7db21...