Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 2731323002: Add a value to PasswordManager.KeychainMigration.Status histogram. (Closed)

Created:
3 years, 9 months ago by vasilii
Modified:
3 years, 9 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a value to PasswordManager.KeychainMigration.Status histogram. It's a follow-up to https://codereview.chromium.org/2729853005/ where MigrationStatus was extended. BUG=595468 Review-Url: https://codereview.chromium.org/2731323002 Cr-Commit-Position: refs/heads/master@{#454939} Committed: https://chromium.googlesource.com/chromium/src/+/fcf82d6e5b20e104b5eaba8d802ee451092126d5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
vasilii
Hi Ilya, please review.
3 years, 9 months ago (2017-03-06 17:04:05 UTC) #4
Ilya Sherman
lgtm
3 years, 9 months ago (2017-03-06 20:17:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2731323002/1
3 years, 9 months ago (2017-03-06 20:18:36 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-06 20:27:20 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fcf82d6e5b20e104b5eaba8d802e...

Powered by Google App Engine
This is Rietveld 408576698