GN: Generate appropriate .dSYMs for .frameworks and .apps

build/toolchain/mac/BUILD.gn

Index: build/toolchain/mac/BUILD.gn
diff --git a/build/toolchain/mac/BUILD.gn b/build/toolchain/mac/BUILD.gn
index b417e76a3b0b9d985f1442503b7b9fd93d6f2e0f..e5783ed98657ef4509f8c5190a6ff3f3288adae9 100644
--- a/build/toolchain/mac/BUILD.gn
+++ b/build/toolchain/mac/BUILD.gn
@@ -172,9 +172,13 @@ template("mac_toolchain") {
 
     # If dSYMs are enabled, this flag will be added to the link tools.
     if (_enable_dsyms) {
-      dsym_switch = " -Wcrl,dsym,{{root_out_dir}} "
-      dsym_output_dir =
-          "{{root_out_dir}}/{{target_output_name}}{{output_extension}}.dSYM"
+      if (defined(invoker.dsym_name)) {

[themblsha, 2017/03/17 15:50:58]

This doesn't actually work, as it seems that I need to forward the |dsym_name|
through all the templates. But the template("mac_toolchain") seems to be
instantiated through the "tool" and I'm not sure how to achieve that.

Maybe you could advice? :-)

[Robert Sesek, 2017/03/17 16:59:36]

I think this is because tool()s are actually special entities in GN that only
inherit specific tool variables (see `gn help tool`).

This may be fairly tricky to pipe through, because technically the link
tool/step doesn't actually know where in the output bundle structure the binary
goes. That's handled by the bundle_data/create_bundle steps, which occur after.

+        dsym_name = invoker.dsym_name
+      } else {
+        dsym_name = "{{target_output_name}}{{output_extension}}.dSYM"
+      }
+      dsym_switch = " -Wcrl,dsym,\{{root_out_dir}},\"$dsym_name\" "
+      dsym_output_dir = "{{root_out_dir}}/$dsym_name"
       dsym_output = [
         "$dsym_output_dir/",
         "$dsym_output_dir/Contents/Info.plist",