Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2925)

Unified Diff: build/config/mac/rules.gni

Issue 2731313004: GN: Generate appropriate .dSYMs for .frameworks and .apps (Closed)
Patch Set: Modify linker_driver.py to create .dSYMs with correct names. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/toolchain/mac/BUILD.gn » ('j') | build/toolchain/mac/BUILD.gn » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/mac/rules.gni
diff --git a/build/config/mac/rules.gni b/build/config/mac/rules.gni
index dd7b4a55508c0830deb8513188dd392740e807b6..cea5ec296d241227c079428ff2255c016988027d 100644
--- a/build/config/mac/rules.gni
+++ b/build/config/mac/rules.gni
@@ -282,6 +282,7 @@ template("mac_framework_bundle") {
_framework_target = _target_name
_framework_name = _output_name + ".framework"
_framework_base_dir = "$root_out_dir/$_framework_name"
+ dsym_name = "${_framework_name}.dSYM"
if (defined(invoker.framework_version) && invoker.framework_version != "") {
_framework_version = invoker.framework_version
_framework_root_dir = _framework_base_dir + "/Versions/$_framework_version"
@@ -503,6 +504,8 @@ template("mac_app_bundle") {
assert(false, "Unsupported packge_type: " + packge_type)
}
+ dsym_name = "${_output_name}.${_output_extension}.dSYM"
+
_executable_target = target_name + "_executable"
_executable_bundle_data = _executable_target + "_bundle_data"
« no previous file with comments | « no previous file | build/toolchain/mac/BUILD.gn » ('j') | build/toolchain/mac/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698