Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 2731313003: Make InsertListCommand::selectionHasListOfType() to take Position objects (Closed)

Created:
3 years, 9 months ago by yosin_UTC9
Modified:
3 years, 9 months ago
Reviewers:
tkent, yoichio, Xiaocheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make InsertListCommand::selectionHasListOfType() to take Position objects instead of VisibleSelection This patch makes |InsertListCommand::selectionHasListOfType()| to take two Position objects for start and end instead of |VisibleSelection| since it uses only start and end of selection to reduce usage of |VisibleSelection| for improving code health. BUG=657237 TEST=n/a Review-Url: https://codereview.chromium.org/2731313003 Cr-Commit-Position: refs/heads/master@{#455371} Committed: https://chromium.googlesource.com/chromium/src/+/ebadc5308f4a935c6e0ddec6fbb466e202913e30

Patch Set 1 : 2017-03-07T14:02:25 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M third_party/WebKit/Source/core/editing/commands/InsertListCommand.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp View 2 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
yosin_UTC9
PTAL
3 years, 9 months ago (2017-03-07 08:04:49 UTC) #8
Xiaocheng
lgtm
3 years, 9 months ago (2017-03-07 18:51:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2731313003/1
3 years, 9 months ago (2017-03-08 00:59:43 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-08 03:26:44 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ebadc5308f4a935c6e0ddec6fbb4...

Powered by Google App Engine
This is Rietveld 408576698