Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java

Issue 2731303002: [NTP::Downloads] Replace 36dp file type resources with vector drawables. (Closed)
Patch Set: dfalcantara@ comment. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java
index 3987060b495cead2c2b6d46d0469fe4516c2e7e7..e7dcb4296b51f0ce23bcb129bc7e4e7f3411379e 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java
@@ -298,24 +298,13 @@ public class SnippetArticleViewHolder extends CardViewHolder implements Impressi
private void setThumbnailFromFileType(int fileType) {
mThumbnailView.setScaleType(ImageView.ScaleType.CENTER_INSIDE);
- // The provided asset is 36dp, but the spec requires 32dp. Add padding to force the asset to
- // be scaled down.
- final int actualIconSizeDp = 36;
- final int desiredIconSizeDp = 32;
- Drawable icon = ApiCompatibilityUtils.getDrawable(mThumbnailView.getResources(),
- DownloadUtils.getIconResId(fileType, DownloadUtils.ICON_SIZE_36_DP));
-
- final int drawableSize = icon.getIntrinsicWidth();
- assert icon.getIntrinsicHeight() == drawableSize;
-
- final int viewSize = mThumbnailView.getResources().getDimensionPixelSize(
- R.dimen.snippets_thumbnail_size);
- final float scale = ((float) desiredIconSizeDp) / actualIconSizeDp;
- final int padding = (int) (viewSize / 2f - drawableSize * scale / 2f);
+ final int padding = mThumbnailView.getResources().getDimensionPixelSize(
gone 2017/03/07 17:08:28 How often is this value reused? Should this be ca
vitaliii 2017/03/08 12:36:50 Done.
+ R.dimen.snippets_thumbnail_file_type_icon_padding);
mThumbnailView.setPadding(padding, padding, padding, padding);
mThumbnailView.setBackgroundColor(mIconBackgroundColor);
- mThumbnailView.setImageDrawable(icon);
+ mThumbnailView.setImageDrawable(ApiCompatibilityUtils.getDrawable(
vitaliii 2017/03/08 12:36:50 This did not work on Android 4.4.2 (device Microma
+ mThumbnailView.getResources(), DownloadUtils.getIconResId(fileType)));
mThumbnailView.setTint(mIconForegroundColorList);
}

Powered by Google App Engine
This is Rietveld 408576698