Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1120)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadItemView.java

Issue 2731303002: [NTP::Downloads] Replace 36dp file type resources with vector drawables. (Closed)
Patch Set: dfalcantara@ comment. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadItemView.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadItemView.java b/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadItemView.java
index b8267521800868fc97ab0b8fc7262522c9cb10a2..dcc011d52d98cba6e474ce1400314d5837f57e68 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadItemView.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadItemView.java
@@ -11,6 +11,7 @@ import android.text.TextUtils;
import android.text.format.Formatter;
import android.util.AttributeSet;
import android.view.View;
+import android.widget.ImageView;
import android.widget.LinearLayout;
import android.widget.TextView;
@@ -153,7 +154,7 @@ public class DownloadItemView extends SelectableItemView<DownloadHistoryItemWrap
}
// Pick what icon to display for the item.
- mIconResId = DownloadUtils.getIconResId(fileType, DownloadUtils.ICON_SIZE_24_DP);
+ mIconResId = DownloadUtils.getIconResId(fileType);
updateIconView();
Context context = mFilesizeView.getContext();
@@ -241,15 +242,25 @@ public class DownloadItemView extends SelectableItemView<DownloadHistoryItemWrap
private void updateIconView() {
if (isChecked()) {
+ mIconView.setScaleType(ImageView.ScaleType.CENTER);
+ mIconView.setPadding(0, 0, 0, 0);
mIconView.setBackgroundColor(mIconBackgroundColorSelected);
mIconView.setImageResource(R.drawable.ic_check_googblue_24dp);
mIconView.setTint(mIconForegroundColorList);
} else if (mThumbnailBitmap != null) {
assert !mThumbnailBitmap.isRecycled();
+ mIconView.setScaleType(ImageView.ScaleType.CENTER);
+ mIconView.setPadding(0, 0, 0, 0);
mIconView.setBackground(null);
mIconView.setImageBitmap(mThumbnailBitmap);
mIconView.setTint(null);
} else {
+ mIconView.setScaleType(ImageView.ScaleType.CENTER_INSIDE);
+
+ final int padding = mIconView.getResources().getDimensionPixelSize(
gone 2017/03/07 17:08:28 This value should be cached as a member variable.
vitaliii 2017/03/08 12:36:50 Done.
+ R.dimen.downloads_item_file_type_icon_padding);
+ mIconView.setPadding(padding, padding, padding, padding);
+
mIconView.setBackgroundColor(mIconBackgroundColor);
mIconView.setImageResource(mIconResId);
mIconView.setTint(mIconForegroundColorList);

Powered by Google App Engine
This is Rietveld 408576698