Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 27313: Merge r9344.... (Closed)

Created:
11 years, 9 months ago by Mark Larson
Modified:
9 years, 7 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Merge r9344. Add UMA counter to track how users launch Chrome - Histogram is named Launch.Modes - We have different buckets for : direct execution, webapp, shell, quicklaunch and desktop shortcuts BUG=7216 Original Review URL: http://codereview.chromium.org/21109 R= CPU Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10682

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -0 lines) Patch
M chrome/browser/browser_init.cc View 1 4 chunks +54 lines, -0 lines 1 comment Download

Messages

Total messages: 2 (0 generated)
Mark Larson
A couple of notes on porting this to the release branch: 1. I fixed the ...
11 years, 9 months ago (2009-02-28 22:59:45 UTC) #1
cpu_(ooo_6.6-7.5)
11 years, 9 months ago (2009-03-01 02:17:03 UTC) #2
Looks good enough to me.

http://codereview.chromium.org/27313/diff/4/5
File chrome/browser/browser_init.cc (right):

http://codereview.chromium.org/27313/diff/4/5#newcode483
Line 483: // LM_AS_WEBAPP.
!Gasp!

Powered by Google App Engine
This is Rietveld 408576698