Add UMA counter to track how users launch Chrome...

Add UMA counter to track how users launch Chrome
- Histogram is named Launch.Modes
- We have different buckets for : direct execution, webapp, shell, quicklaunch and desktop shortcuts

BUG=7216
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=9344

[jar (doing other things), 2009-02-06 02:47:19]

Patch LGTM, but I had two naming suggestions.

http://codereview.chromium.org/21109/diff/1003/3
File chrome/browser/browser_init.cc (right):

http://codereview.chromium.org/21109/diff/1003/3#newcode139
Line 139: LM_NO_URLS,                 // Launched as a regular browser.
This constant is really not used in the histogram, and you might want to push it
to the end (top or bottom), and also might want to call it something more
descriptive such as LM_TO_BE_DECIDED (since it is really a flag to get more
analysis I think).

http://codereview.chromium.org/21109/diff/1003/3#newcode172
Line 172: return LM_SHORTCUT_NONE;
I'd suggest you use a distinct macro, like
LM_SHORTCUT_NON_WINDOWS
This way, when we do get ported, folks won't confuse your stats.

[dhhwai, 2009-02-06 23:47:50]

http://codereview.chromium.org/21109/diff/1006/1007
File chrome/browser/browser_init.cc (right):

http://codereview.chromium.org/21109/diff/1006/1007#newcode153
Line 153: LaunchMode GetLaunchSortcutKind() {
spelling should be: GetLaunchShortcutKind

http://codereview.chromium.org/21109/diff/1006/1007#newcode173
Line 173: LaunchMode GetLaunchSortcutKind() {
spelling should be: GetLaunchShortcutKind

[cpu_(ooo_6.6-7.5), 2009-02-07 02:32:52]

Sorry about that, I'll fix it soon.


On 2009/02/06 23:47:50, dhhwai wrote:
> http://codereview.chromium.org/21109/diff/1006/1007
> File chrome/browser/browser_init.cc (right):
> 
> http://codereview.chromium.org/21109/diff/1006/1007#newcode153
> Line 153: LaunchMode GetLaunchSortcutKind() {
> spelling should be: GetLaunchShortcutKind
> 
> http://codereview.chromium.org/21109/diff/1006/1007#newcode173
> Line 173: LaunchMode GetLaunchSortcutKind() {
> spelling should be: GetLaunchShortcutKind