Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Unified Diff: third_party/WebKit/Source/platform/mhtml/MHTMLArchive.h

Issue 2731293004: Move the writing of the MHTML footer to the browser process. (Closed)
Patch Set: More minor changes Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_frame_impl.cc ('k') | third_party/WebKit/Source/platform/mhtml/MHTMLArchive.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/mhtml/MHTMLArchive.h
diff --git a/third_party/WebKit/Source/platform/mhtml/MHTMLArchive.h b/third_party/WebKit/Source/platform/mhtml/MHTMLArchive.h
index c538d24ea77f782ad44c205bd3ecf02df7218935..54c713f9ac1f038591dd096ee3f8b7bfc3dbef32 100644
--- a/third_party/WebKit/Source/platform/mhtml/MHTMLArchive.h
+++ b/third_party/WebKit/Source/platform/mhtml/MHTMLArchive.h
@@ -55,7 +55,7 @@ class PLATFORM_EXPORT MHTMLArchive final
// Generates an MHTML header and appends it to |outputBuffer|.
//
- // Same |boundary| needs to used for all generateMHTMLHeader and
+ // Same |boundary| needs to be used for all generateMHTMLHeader and
// generateMHTMLPart and generateMHTMLFooter calls that belong to the same
// MHTML document (see also rfc1341, section 7.2.1, "boundary" description).
static void generateMHTMLHeader(const String& boundary,
@@ -66,7 +66,7 @@ class PLATFORM_EXPORT MHTMLArchive final
// Serializes SerializedResource as an MHTML part and appends it in
// |outputBuffer|.
//
- // Same |boundary| needs to used for all generateMHTMLHeader and
+ // Same |boundary| needs to be used for all generateMHTMLHeader and
// generateMHTMLPart and generateMHTMLFooter calls that belong to the same
// MHTML document (see also rfc1341, section 7.2.1, "boundary" description).
//
@@ -78,13 +78,14 @@ class PLATFORM_EXPORT MHTMLArchive final
const SerializedResource&,
Vector<char>& outputBuffer);
- // Generates an MHTML footer and appends it to |outputBuffer|.
+ // Generates an MHTML footer and appends it to |outputBuffer| for testing
+ // purposes.
//
- // Same |boundary| needs to used for all generateMHTMLHeader and
+ // Same |boundary| needs to be used for all generateMHTMLHeader and
// generateMHTMLPart and generateMHTMLFooter calls that belong to the same
// MHTML document (see also rfc1341, section 7.2.1, "boundary" description).
- static void generateMHTMLFooter(const String& boundary,
- Vector<char>& outputBuffer);
+ static void generateMHTMLFooterForTesting(const String& boundary,
+ Vector<char>& outputBuffer);
typedef HeapHashMap<String, Member<ArchiveResource>> SubArchiveResources;
« no previous file with comments | « content/renderer/render_frame_impl.cc ('k') | third_party/WebKit/Source/platform/mhtml/MHTMLArchive.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698