Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1409)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 2731293004: Move the writing of the MHTML footer to the browser process. (Closed)
Patch Set: More minor changes Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/common/frame_messages.h ('k') | third_party/WebKit/Source/platform/mhtml/MHTMLArchive.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index 4af9b671725620814b3f5d10384a881f4c68d83a..2e8f6a1bf9f365910cf4b918cc3cbe74679c0e1a 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -5544,14 +5544,8 @@ void RenderFrameImpl::OnSerializeAsMHTML(
has_some_data |= !mhtml_contents.back().isEmpty();
}
- // Generate MHTML footer if needed.
- if (save_status == MhtmlSaveStatus::SUCCESS && params.is_last_frame) {
- TRACE_EVENT0("page-serialization",
- "RenderFrameImpl::OnSerializeAsMHTML footer");
- mhtml_contents.emplace_back(
- WebFrameSerializer::generateMHTMLFooter(mhtml_boundary));
- has_some_data |= !mhtml_contents.back().isEmpty();
- }
+ // Note: the MHTML footer is written by the browser process, after the last
+ // frame is serialized by a renderer process.
// Note: we assume RenderFrameImpl::OnWriteMHTMLToDiskComplete and the rest of
// this function will be fast enough to not need to be accounted for in this
« no previous file with comments | « content/common/frame_messages.h ('k') | third_party/WebKit/Source/platform/mhtml/MHTMLArchive.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698