Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2731283006:
Update HistoryStateOperationsTest waits to include failure messages. (Closed)
|
Created:
3 years, 9 months ago by michaeldo Modified:
3 years, 9 months ago Reviewers:
Eugene But (OOO till 7-30) CC:
chromium-reviews, Eugene But (OOO till 7-30), ios-reviews+web_chromium.org, ios-reviews_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionUpdate HistoryStateOperationsTest waits to include failure messages.
BUG=none
Review-Url: https://codereview.chromium.org/2731283006
Cr-Commit-Position: refs/heads/master@{#455509}
Committed: https://chromium.googlesource.com/chromium/src/+/ea7c380cd11563d17535465c740cc574f4accda9
Patch Set 1 #
Total comments: 4
Patch Set 2 : Update timeouts. #Patch Set 3 : Add timeout constant for state updates. #Patch Set 4 : Add missing dep. #Messages
Total messages: 21 (10 generated)
michaeldo@chromium.org changed reviewers: + eugenebut@chromium.org
https://codereview.chromium.org/2731283006/diff/1/ios/web/navigation/history_... File ios/web/navigation/history_state_operations_inttest.mm (right): https://codereview.chromium.org/2731283006/diff/1/ios/web/navigation/history_... ios/web/navigation/history_state_operations_inttest.mm:114: testing::kWaitForJSCompletionTimeout, ^{ This does not look like JS execution. Is there a better constant? Same question for other places.
https://codereview.chromium.org/2731283006/diff/1/ios/web/navigation/history_... File ios/web/navigation/history_state_operations_inttest.mm (right): https://codereview.chromium.org/2731283006/diff/1/ios/web/navigation/history_... ios/web/navigation/history_state_operations_inttest.mm:114: testing::kWaitForJSCompletionTimeout, ^{ On 2017/03/07 21:10:38, Eugene But wrote: > This does not look like JS execution. Is there a better constant? > > Same question for other places. This one is JS execution (defined in the helper above). However some of them are not, I think we should use kWaitForPageLoadTimeout if it is not JS execution. PTAL at the updated patch.
lgtm https://codereview.chromium.org/2731283006/diff/1/ios/web/navigation/history_... File ios/web/navigation/history_state_operations_inttest.mm (right): https://codereview.chromium.org/2731283006/diff/1/ios/web/navigation/history_... ios/web/navigation/history_state_operations_inttest.mm:114: testing::kWaitForJSCompletionTimeout, ^{ On 2017/03/07 22:21:54, michaeldo wrote: > On 2017/03/07 21:10:38, Eugene But wrote: > > This does not look like JS execution. Is there a better constant? > > > > Same question for other places. > > This one is JS execution (defined in the helper above). However some of them are > not, I think we should use kWaitForPageLoadTimeout if it is not JS execution. > PTAL at the updated patch. Those are all State Update operations, which is half native code half JS. And they don't load the page. Can you create a separate constant for them in this file?
https://codereview.chromium.org/2731283006/diff/1/ios/web/navigation/history_... File ios/web/navigation/history_state_operations_inttest.mm (right): https://codereview.chromium.org/2731283006/diff/1/ios/web/navigation/history_... ios/web/navigation/history_state_operations_inttest.mm:114: testing::kWaitForJSCompletionTimeout, ^{ On 2017/03/08 00:55:00, Eugene But wrote: > On 2017/03/07 22:21:54, michaeldo wrote: > > On 2017/03/07 21:10:38, Eugene But wrote: > > > This does not look like JS execution. Is there a better constant? > > > > > > Same question for other places. > > > > This one is JS execution (defined in the helper above). However some of them > are > > not, I think we should use kWaitForPageLoadTimeout if it is not JS execution. > > PTAL at the updated patch. > Those are all State Update operations, which is half native code half JS. And > they don't load the page. Can you create a separate constant for them in this > file? Thanks for the explanation, it wasn't immediately clear what was updated this state. I've added a constant and used the JS timeout amount for it of 2.0.
The CQ bit was checked by michaeldo@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from eugenebut@chromium.org Link to the patchset: https://codereview.chromium.org/2731283006/#ps40001 (title: "Add timeout constant for state updates.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
The CQ bit was checked by michaeldo@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from eugenebut@chromium.org Link to the patchset: https://codereview.chromium.org/2731283006/#ps60001 (title: "Add missing dep.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by michaeldo@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1488997285832150,
"parent_rev": "37adeac7017da79020cfaf91b07f1f8d8c371b2e", "commit_rev":
"ea7c380cd11563d17535465c740cc574f4accda9"}
Message was sent while issue was closed.
Description was changed from ========== Update HistoryStateOperationsTest waits to include failure messages. BUG=none ========== to ========== Update HistoryStateOperationsTest waits to include failure messages. BUG=none Review-Url: https://codereview.chromium.org/2731283006 Cr-Commit-Position: refs/heads/master@{#455509} Committed: https://chromium.googlesource.com/chromium/src/+/ea7c380cd11563d17535465c740c... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/ea7c380cd11563d17535465c740c... |
