Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 2731283003: (Reland) Discard compositor frames from unloaded web content (Closed)

Created:
3 years, 9 months ago by kenrb
Modified:
3 years, 9 months ago
Reviewers:
danakj, Charlie Reis
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, nasko+codewatch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, piman+watch_chromium.org, cc-bugs_chromium.org, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

(Reland) Discard compositor frames from unloaded web content This is a reland of https://codereview.chromium.org/2707243005/ with a small change to fix an uninitialized memory error that fails on MSAN bots. BUG=672847 TBR=danakj@chromium.org, creis@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2731283003 Cr-Commit-Position: refs/heads/master@{#454954} Committed: https://chromium.googlesource.com/chromium/src/+/5d78b84d39bd34bc9fce9d01c0dcd5a22a330d34

Patch Set 1 #

Patch Set 2 : Initialize field to zero #

Unified diffs Side-by-side diffs Delta from patch set Stats (+169 lines, -8 lines) Patch
M cc/ipc/cc_param_traits_macros.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/ipc/compositor_frame_metadata.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M cc/ipc/compositor_frame_metadata_struct_traits.h View 1 chunk +5 lines, -0 lines 0 comments Download
M cc/ipc/compositor_frame_metadata_struct_traits.cc View 1 chunk +1 line, -0 lines 0 comments Download
M cc/ipc/struct_traits_unittest.cc View 3 chunks +3 lines, -0 lines 0 comments Download
M cc/output/compositor_frame_metadata.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host.h View 2 chunks +5 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host.cc View 3 chunks +10 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 1 chunk +27 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_impl.h View 2 chunks +5 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_impl.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.h View 2 chunks +12 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 3 chunks +11 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_unittest.cc View 4 chunks +36 lines, -3 lines 0 comments Download
M content/common/frame_messages.h View 1 chunk +5 lines, -0 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M content/renderer/render_widget.h View 2 chunks +16 lines, -0 lines 0 comments Download
M content/renderer/render_widget.cc View 3 chunks +11 lines, -0 lines 0 comments Download
M content/test/test_render_view_host.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (9 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2731283003/20001
3 years, 9 months ago (2017-03-06 20:55:05 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-06 21:06:52 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5d78b84d39bd34bc9fce9d01c0dc...

Powered by Google App Engine
This is Rietveld 408576698