Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2731263002: Use UTF-8 rather than UNICODE for the OpenFile w/ character set test. (Closed)

Created:
3 years, 9 months ago by grt (UTC plus 2)
Modified:
3 years, 9 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use UTF-8 rather than UNICODE for the OpenFile w/ character set test. This makes the test pass on chromecast devices, which presumably don't support UNICODE. The exact value isn't important for the test. BUG=698396 Review-Url: https://codereview.chromium.org/2731263002 Cr-Commit-Position: refs/heads/master@{#454859} Committed: https://chromium.googlesource.com/chromium/src/+/4d62f880e739c41ddd24b2c5e54a9dfe05033789

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M base/files/file_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
grt (UTC plus 2)
PTAL. Feel free to check the CQ box if it lgty. Thanks.
3 years, 9 months ago (2017-03-06 11:31:59 UTC) #7
Mark Mentovai
LGTM
3 years, 9 months ago (2017-03-06 12:37:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2731263002/1
3 years, 9 months ago (2017-03-06 13:21:25 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-06 13:25:51 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4d62f880e739c41ddd24b2c5e54a...

Powered by Google App Engine
This is Rietveld 408576698