Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 2731243002: Make NeedsReattachLayoutTree and ChildNeedsReattachLayoutTree getters const (Closed)

Created:
3 years, 9 months ago by nainar
Modified:
3 years, 9 months ago
Reviewers:
sashab
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make NeedsReattachLayoutTree and ChildNeedsReattachLayoutTree getters const This patch makes the needsReattachLayoutTree() and childNeedsReattachLayoutTree() const. This mimics the needsStyleRecalc() and childNeedsStyleRecalc() functions. BUG=595137 Review-Url: https://codereview.chromium.org/2731243002 Cr-Commit-Position: refs/heads/master@{#454830} Committed: https://chromium.googlesource.com/chromium/src/+/615bbb898b2b62c1e1720d4278aba988662cc77b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M third_party/WebKit/Source/core/dom/Node.h View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
nainar
Sasha, Could you take a quick look. Just a code health change.
3 years, 9 months ago (2017-03-06 03:38:52 UTC) #4
sashab
lgtm
3 years, 9 months ago (2017-03-06 05:23:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2731243002/1
3 years, 9 months ago (2017-03-06 05:24:24 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-06 05:28:49 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/615bbb898b2b62c1e1720d4278ab...

Powered by Google App Engine
This is Rietveld 408576698